Revert "stop wrapping our custom js loading in a require block"

This reverts commit 78268a8.

fixes CNVS-30696

test plan:
- add a custom account js include
- make sure it loads properly all the time

Change-Id: Ie708c17c7d27c6caaf46a79df115557737701286
Reviewed-on: https://gerrit.instructure.com/86596
Tested-by: Jenkins
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com>
Product-Review: Benjamin Christian Nelson <bcnelson@instructure.com>

Author: simonista

app/helpers/application_helper.rb

@@ -796,19 +796,13 @@ def include_account_js(options = {})
         javascript_include_tag(*includes)
       else
         str = <<-ENDSCRIPT
-          !function(){
-            function tryToLoadAccountJS () {
-              // wait to make sure jquery is loaded before loading account js
-              if (!$) return setTimeout(tryToLoadAccountJS, 20);
-
-              #{includes.to_json}.forEach(function (src) {
-                var s = document.createElement('script');
-                s.src = src;
-                document.body.appendChild(s);
-              });
-            }
-            tryToLoadAccountJS();
-          }();
+          require(['jquery'], function () {
+            #{includes.to_json}.forEach(function (src) {
+              var s = document.createElement('script');
+              s.src = src;
+              document.body.appendChild(s);
+            });
+          });
         ENDSCRIPT
         javascript_tag(str)
       end