rename SIS::CSV::BaseImporter to SIS::CSV::CSVBaseImporter

There is also a SIS::BaseImporter in the outer module/namespace, which
makes having the same class name in a nested module really error prone.

Change-Id: Ia61f87088748212f855577570a28871c06fe87d9
Reviewed-on: https://gerrit.instructure.com/19292
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Duane Johnson <duane@instructure.com>
QA-Review: Clare Hetherington <clare@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>

Author: codekitchen

lib/sis/csv/abstract_course_importer.rb

@@ -18,7 +18,7 @@
 
 module SIS
   module CSV
-    class AbstractCourseImporter < BaseImporter
+    class AbstractCourseImporter < CSVBaseImporter
 
       def self.is_abstract_course_csv?(row)
         row.include?('abstract_course_id') && !row.include?('course_id') && row.include?('short_name')

lib/sis/csv/account_importer.rb

@@ -18,7 +18,7 @@
 
 module SIS
   module CSV
-    class AccountImporter < BaseImporter
+    class AccountImporter < CSVBaseImporter
 
       def self.is_account_csv?(row)
         row.include?('account_id') && row.include?('parent_account_id')

lib/sis/csv/course_importer.rb

@@ -18,7 +18,7 @@
 
 module SIS
   module CSV
-    class CourseImporter < BaseImporter
+    class CourseImporter < CSVBaseImporter
 
       def self.is_course_csv?(row)
         row.include?('course_id') && row.include?('short_name')

lib/sis/csv/base_importer.rb lib/sis/csv/csv_base_importer.rblib/sis/csv/base_importer.rb renamed to lib/sis/csv/csv_base_importer.rb

@@ -20,7 +20,7 @@
 
 module SIS
   module CSV
-    class BaseImporter
+    class CSVBaseImporter
       PARSE_ARGS = {:headers => :first_row,
                   :skip_blanks => true,
                   :header_converters => :downcase,

lib/sis/csv/enrollment_importer.rb

@@ -18,7 +18,7 @@
 
 module SIS
   module CSV
-    class EnrollmentImporter < BaseImporter
+    class EnrollmentImporter < CSVBaseImporter
 
       def self.is_enrollment_csv?(row)
         (row.include?('section_id') || row.include?('course_id')) && row.include?('user_id')

lib/sis/csv/grade_publishing_results_importer.rb

@@ -18,7 +18,7 @@
 
 module SIS
   module CSV
-    class GradePublishingResultsImporter < BaseImporter
+    class GradePublishingResultsImporter < CSVBaseImporter
 
       def self.is_grade_publishing_results_csv?(row)
         row.include?('enrollment_id') && row.include?('grade_publishing_status')

lib/sis/csv/group_importer.rb

@@ -19,7 +19,7 @@
 module SIS
   module CSV
     # note these are account-level groups, not course groups
-    class GroupImporter < BaseImporter
+    class GroupImporter < CSVBaseImporter
       def self.is_group_csv?(row)
         row.include?('group_id') && row.include?('name')
       end

lib/sis/csv/group_membership_importer.rb

@@ -18,7 +18,7 @@
 
 module SIS
   module CSV
-    class GroupMembershipImporter < BaseImporter
+    class GroupMembershipImporter < CSVBaseImporter
       def self.is_group_membership_csv?(row)
         row.include?('group_id') && row.include?('user_id')
       end

lib/sis/csv/import.rb

@@ -108,7 +108,7 @@ def process
           @csvs[importer].reject! do |csv|
             begin
               rows = 0
-              FasterCSV.open(csv[:fullpath], "rb", BaseImporter::PARSE_ARGS) do |faster_csv|
+              FasterCSV.open(csv[:fullpath], "rb", CSVBaseImporter::PARSE_ARGS) do |faster_csv|
                 rows += 1 while faster_csv.shift
               end
               @rows[importer] += rows
@@ -336,7 +336,7 @@ def rebalance_csvs(importer)
           Attachment.skip_3rd_party_submits
           @csvs[importer].each do |csv|
             remaining_in_batch = 0
-            FasterCSV.foreach(csv[:fullpath], BaseImporter::PARSE_ARGS) do |row|
+            FasterCSV.foreach(csv[:fullpath], CSVBaseImporter::PARSE_ARGS) do |row|
               if remaining_in_batch == 0
                 temp_file += 1
                 if out_csv
@@ -399,7 +399,7 @@ def process_file(base, file)
             return
           end
           begin
-            FasterCSV.foreach(csv[:fullpath], BaseImporter::PARSE_ARGS.merge(:headers => false)) do |row|
+            FasterCSV.foreach(csv[:fullpath], CSVBaseImporter::PARSE_ARGS.merge(:headers => false)) do |row|
               row.each(&:downcase!)
               importer = IMPORTERS.index do |importer|
                 if SIS::CSV.const_get(importer.to_s.camelcase + 'Importer').send('is_' + importer.to_s + '_csv?', row)

lib/sis/csv/section_importer.rb

@@ -18,7 +18,7 @@
 
 module SIS
   module CSV
-    class SectionImporter < BaseImporter
+    class SectionImporter < CSVBaseImporter
 
       def self.is_section_csv?(row)
         #This matcher works because an enrollment doesn't have name