fix module item workflow state syncing issues with course copy

test plan:
* create an assignment/wiki page/etc and publish it
* copy it over to a new course
* unpublish the copied content
* in the original course, add the content as a
module item
* do another copy from the original course to the
 copied course, but use "select content" to only
 select the module for copy
* the copied module item should be unpublished, like
 the content it refers to

closes #CNVS-32532

Change-Id: Ic049b8212e8b97af80823e7f70851daf0e38e86a
Reviewed-on: https://gerrit.instructure.com/93912
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>

Author: maneframe

app/models/importers/context_module_importer.rb

@@ -299,7 +299,7 @@ def self.add_module_item_from_migration(context_module, hash, level, context, it
         item.migration_id = hash[:migration_id]
         item.new_tab = hash[:new_tab]
         item.position = (context_module.item_migration_position ||= context_module.content_tags.not_deleted.map(&:position).compact.max || 0)
-        if hash[:workflow_state] && !['active', 'published'].include?(item.workflow_state)
+        if hash[:workflow_state] && ContentTag::TABLELESS_CONTENT_TYPES.include?(item.content_type) && !['active', 'published'].include?(item.workflow_state)
           item.workflow_state = hash[:workflow_state]
         end
         context_module.item_migration_position += 1

app/models/importers/wiki_page_importer.rb

@@ -66,7 +66,7 @@ def self.import_from_migration(hash, context, migration, item=nil)
       hide_from_students = hash[:hide_from_students] if !hash[:hide_from_students].nil?
       state = hash[:workflow_state]
       if state || !hide_from_students.nil?
-        if state == 'active' && Canvas::Plugin.value_to_boolean(hide_from_students) == false
+        if state == 'active' && !item.unpublished? && Canvas::Plugin.value_to_boolean(hide_from_students) == false
           item.workflow_state = 'active'
         else
           item.workflow_state = 'unpublished' if item.new_record? || item.deleted?

spec/models/content_migration/course_copy_spec.rb

@@ -591,5 +591,46 @@
       new_topic = @copy_to.discussion_topics.where(:migration_id => mig_id(topic)).first
       expect(new_topic.message).to match(Regexp.new("/courses/#{@copy_to.id}/files/folder/#{folder.name}"))
     end
+
+    it "should not desync imported module item published status with existing content" do
+      asmnt = @copy_from.assignments.create!(:title => "some assignment")
+      page = @copy_from.wiki.wiki_pages.create!(:title => "some page")
+
+      run_course_copy
+
+      new_asmnt = @copy_to.assignments.where(:migration_id => mig_id(asmnt)).first
+      new_asmnt.unpublish!
+
+      new_page = @copy_to.wiki.wiki_pages.where(:migration_id => mig_id(page)).first
+      new_page.unpublish!
+
+      mod1 = @copy_from.context_modules.create!(:name => "some module")
+      tag = mod1.add_item({:id => asmnt.id, :type => 'assignment', :indent => 1})
+      tag2 = mod1.add_item({:id => page.id, :type => 'wiki_page', :indent => 1})
+
+      @cm.copy_options = {:all_context_modules => "1"}
+      @cm.save!
+      run_course_copy
+
+      new_tag = @copy_to.context_module_tags.where(:migration_id => mig_id(tag)).first
+      expect(new_tag).to be_unpublished
+
+      new_tag2 = @copy_to.context_module_tags.where(:migration_id => mig_id(tag2)).first
+      expect(new_tag2).to be_unpublished
+    end
+
+    it "should copy over published tableless module items" do
+      mod = @copy_from.context_modules.create!(:name => "some module")
+      tag1 = mod.add_item({ :title => 'Example 1', :type => 'external_url', :url => 'http://derp.derp/something' })
+      tag1.publish!
+      tag2 = mod.add_item({ :title => 'Example 2', :type => 'external_url', :url => 'http://derp.derp/something2' })
+
+      run_course_copy
+
+      new_tag1 = @copy_to.context_module_tags.where(:migration_id => mig_id(tag1)).first
+      new_tag2 = @copy_to.context_module_tags.where(:migration_id => mig_id(tag2)).first
+      expect(new_tag1).to be_published
+      expect(new_tag2).to be_unpublished
+    end
   end
 end