Make course checklist status accurate

Fixes CNVS-22241

Test Plan:
1) Create new course
2) Navigate to Course Setup Checklist on the Home view
3) Follow each item in the checklist and ensure each item
   is checked off correctly as you complete them

Change-Id: Ia65ab7817dcd330107701e6e6641941343d72d24
Reviewed-on: https://gerrit.instructure.com/59999
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Brock Cooper <bcooper@instructure.com>

Author: Brock Cooper

app/controllers/courses_controller.rb

@@ -1514,7 +1514,7 @@ def show
             :add_students => course_users_path(course_id: @context),
             :add_files => context_url(@context, :context_files_url, :wizard => 1),
             :select_navigation => context_url(@context, :context_details_url),
-            :course_calendar => calendar_path(:wizard => 1),
+            :course_calendar => calendar_path(course_id: @context),
             :add_tas => course_users_path(:course_id => @context),
             :publish_course => course_path(@context)
           },

app/jsx/course_wizard/ListItems.jsx

@@ -3,43 +3,45 @@ define([
   ], function (I18n) {
     /**
      * Returns an array containing all the possible items for the checklist
+     * For many ListItems, the ! is added for the complete property
+     *  because the ENV is checking if the step is nil? or empty?
      */
     return [
       {
         key:'content_import',
-        complete: ENV.COURSE_WIZARD.checklist_states.import_step,
+        complete: !ENV.COURSE_WIZARD.checklist_states.import_step,
         title: I18n.t("Import Content"),
         text: I18n.t("If you've been using another course management system, you probably have stuff in there that you're going to want moved over to Canvas. We can walk you through the process of easily migrating your content into Canvas."),
         url: ENV.COURSE_WIZARD.urls.content_import,
         iconClass: 'icon-upload'
       },
       {
         key:'add_assignments',
-        complete: ENV.COURSE_WIZARD.checklist_states.assignment_step,
+        complete: !ENV.COURSE_WIZARD.checklist_states.assignment_step,
         title: I18n.t("Add Course Assignments"),
         text: I18n.t("Add your assignments.  You can just make a long list, or break them up into groups - and even specify weights for each assignment group."),
         url: ENV.COURSE_WIZARD.urls.add_assignments,
         iconClass: 'icon-assignment'
       },
       {
         key:'add_students',
-        complete: ENV.COURSE_WIZARD.checklist_states.add_student_step,
+        complete: !ENV.COURSE_WIZARD.checklist_states.add_student_step,
         title: I18n.t("Add Students to the Course"),
         text: I18n.t("You'll definitely want some of these.  What's the fun of teaching a course if nobody's even listening?"),
         url: ENV.COURSE_WIZARD.urls.add_students,
         iconClass: 'icon-group-new'
       },
       {
         key:'add_files',
-        complete: ENV.COURSE_WIZARD.checklist_states.import_step, /* Super odd in the existing wizard this is set to display: none */
+        complete: !ENV.COURSE_WIZARD.checklist_states.import_step, /* Super odd in the existing wizard this is set to display: none */
         title: I18n.t("Add Files to the Course"),
         text: I18n.t("The Files tab is the place to share lecture slides, example documents, study helps -- anything your students will want to download.  Uploading and organizing your files is easy with Canvas.  We'll show you how."),
         url: ENV.COURSE_WIZARD.urls.add_files,
         iconClass: 'icon-note-light'
       },
       {
         key:'select_navigation',
-        complete: ENV.COURSE_WIZARD.checklist_states.navigation_step,
+        complete: !ENV.COURSE_WIZARD.checklist_states.navigation_step,
         title: I18n.t("Select Navigation Links"),
         text: I18n.t("By default all links are enabled for a course.  Students won't see links to sections that don't have content.  For example, if you haven't created any quizzes, they won't see the quizzes link.  You can sort and explicitly disable these links if there are areas of the course you don't want your students accessing."),
         url: ENV.COURSE_WIZARD.urls.select_navigation,
@@ -54,15 +56,15 @@ define([
       },
       {
         key:'course_calendar',
-        complete: ENV.COURSE_WIZARD.checklist_states.calendar_event_step,
+        complete: !ENV.COURSE_WIZARD.checklist_states.calendar_event_step,
         title: I18n.t("Add Course Calendar Events"),
         text: I18n.t("Here's a great chance to get to know the calendar and add any non-assignment events you might have to the course. Don't worry, we'll help you through it."),
         url: ENV.COURSE_WIZARD.urls.course_calendar,
         iconClass: 'icon-calendar-month'
       },
       {
         key:'add_tas',
-        complete: ENV.COURSE_WIZARD.checklist_states.add_ta_step,
+        complete: !ENV.COURSE_WIZARD.checklist_states.add_ta_step,
         title: I18n.t("Add TAs to the Course"),
         text: I18n.t("You may want to assign some TAs to help you with the course.  TAs can grade student submissions, help moderate the discussions and even update due dates and assignment details for you."),
         url: ENV.COURSE_WIZARD.urls.add_tas,

spec/selenium/courses_spec.rb

@@ -89,78 +89,172 @@ def validate_action_button(postion, validation_text)
 
     end
 
-    it "should properly hide the wizard and remember its hidden state" do
-      # For now we are not allowing the wizard to popup automatically
-      # so this spec doesn't apply, it may in the future though.
-      pending
-      course_with_teacher_logged_in
-
-      create_new_course
+    describe 'course wizard' do
+      def go_to_checklist
+        get "/courses/#{@course.id}"
+        f(".wizard_popup_link").click()
+        wizard_box = f(".ic-wizard-box")
+        keep_trying_until { expect(wizard_box).to be_displayed }
+      end
 
-      wizard_box = f(".ic-wizard-box")
-      keep_trying_until { expect(wizard_box).to be_displayed }
-      f(".ic-wizard-box__close a").click
+      def check_if_item_complete(item)
+        elem = "#wizard_#{item}.ic-wizard-box__content-trigger--checked"
+        expect(f(elem)).to be_displayed
+      end
 
-      refresh_page
-      wait_for_ajaximations # we need to give the wizard a chance to pop up
-      wizard_box = f(".ic-wizard-box")
-      expect(wizard_box).to eq nil
+      def check_if_item_not_complete(item)
+        expect(f("#wizard_#{item}.ic-wizard-box__content-trigger")).to be_displayed
+        expect(f("#wizard_#{item}.ic-wizard-box__content-trigger--checked")).to be_nil
+      end
 
-      # un-remember the setting
-      driver.execute_script "localStorage.clear()"
-    end
+      it "should properly hide the wizard and remember its hidden state" do
+        # For now we are not allowing the wizard to popup automatically
+        # so this spec doesn't apply, it may in the future though.
+        pending
+        course_with_teacher_logged_in
+        create_new_course
+        wizard_box = f(".ic-wizard-box")
+        keep_trying_until { expect(wizard_box).to be_displayed }
+        f(".ic-wizard-box__close a").click
+        refresh_page
+        wait_for_ajaximations # we need to give the wizard a chance to pop up
+        wizard_box = f(".ic-wizard-box")
+        expect(wizard_box).to eq nil
+        # un-remember the setting
+        driver.execute_script "localStorage.clear()"
+      end
 
-    it "should open and close wizard after initial close" do
-      # For now we are not allowing the wizard to popup automatically
-      # so this spec doesn't apply, it may in the future though.
-      pending
-      def find_wizard_box
-        wizard_box = keep_trying_until do
-          wizard_box = f(".ic-wizard-box")
-          expect(wizard_box).to be_displayed
+      it "should open and close wizard after initial close" do
+        # For now we are not allowing the wizard to popup automatically
+        # so this spec doesn't apply, it may in the future though.
+        pending
+        def find_wizard_box
+          wizard_box = keep_trying_until do
+            wizard_box = f(".ic-wizard-box")
+            expect(wizard_box).to be_displayed
+            wizard_box
+          end
           wizard_box
         end
-        wizard_box
+
+        course_with_teacher_logged_in
+        create_new_course
+
+        wait_for_ajaximations
+        wizard_box = find_wizard_box
+        f(".ic-wizard-box__close a").click
+        wait_for_ajaximations
+        wizard_box = f(".ic-wizard-box")
+        expect(wizard_box).to eq nil
+        checklist_button = f('.wizard_popup_link')
+        expect(checklist_button).to be_displayed
+        checklist_button.click
+        wait_for_ajaximations
+        wizard_box = find_wizard_box
+        f(".ic-wizard-box__close a").click
+        wait_for_ajaximations
+        wizard_box = f(".ic-wizard-box")
+        expect(wizard_box).to eq nil
+        expect(checklist_button).to be_displayed
       end
 
-      course_with_teacher_logged_in
-      create_new_course
+      it "should open up the choose home page dialog from the wizard" do
+        course_with_teacher_logged_in
+        create_new_course
+
+        # Because of the specs about automatically opening are currently
+        # pending, we need to cause the wizard to open by way of click. When
+        # those specs are no longer pendings, the click line should be removed.
+        go_to_checklist
+
+        f("#wizard_home_page").click
+        f(".ic-wizard-box__message-button a").click
+        wait_for_ajaximations
+        modal = f("#edit_course_home_content_form")
+        expect(modal).to be_displayed
+      end
 
-      wait_for_ajaximations
-      wizard_box = find_wizard_box
-      f(".ic-wizard-box__close a").click
-      wait_for_ajaximations
-      wizard_box = f(".ic-wizard-box")
-      expect(wizard_box).to eq nil
-      checklist_button = f('.wizard_popup_link')
-      expect(checklist_button).to be_displayed
-      checklist_button.click
-      wait_for_ajaximations
-      wizard_box = find_wizard_box
-      f(".ic-wizard-box__close a").click
-      wait_for_ajaximations
-      wizard_box = f(".ic-wizard-box")
-      expect(wizard_box).to eq nil
-      expect(checklist_button).to be_displayed
-    end
+      it "should have the correct initial state" do
+        course_with_teacher_logged_in
+        go_to_checklist
+
+        check_if_item_not_complete('content_import')
+        check_if_item_not_complete('add_assignments')
+        check_if_item_not_complete('add_students')
+        check_if_item_not_complete('add_files')
+        check_if_item_not_complete('content_import')
+        check_if_item_not_complete('select_navigation')
+        check_if_item_complete('home_page')
+        check_if_item_not_complete('course_calendar')
+        check_if_item_not_complete('add_tas')
+      end
 
-    it "should open up the choose home page dialog from the wizard" do
-      course_with_teacher_logged_in
-      create_new_course
+      it "should complete 'Add Course Assignments' checklist item" do
+        course_with_teacher_logged_in
+        @course.assignments.create({name: "Test Assignment"})
+        go_to_checklist
+        check_if_item_complete('add_assignments')
+      end
 
-      # Because of the specs about automatically opening are currently
-      # pending, we need to cause the wizard to open by way of click. When
-      # those specs are no longer pendings, the click line should be removed.
-      f(".wizard_popup_link").click()
-      wizard_box = f(".ic-wizard-box")
-      keep_trying_until { expect(wizard_box).to be_displayed }
+      it "should complete 'Add Students to the Course' checklist item" do
+        course_with_teacher_logged_in
+        student = user_with_pseudonym(:username => 'student@example.com', :active_all => 1)
+        student_in_course(:user => student, :active_all => 1)
+        go_to_checklist
+        check_if_item_complete('add_students')
+      end
 
+      it "should complete 'Select Navigation Links' checklist item" do
+        course_with_teacher_logged_in
+        get "/courses/#{@course.id}"
 
-      f("#wizard_home_page").click
-      f(".ic-wizard-box__message-button a").click
-      wait_for_ajaximations
-      modal = f("#edit_course_home_content_form")
-      expect(modal).to be_displayed
+        # Navigate to Navigation tab
+        go_to_checklist
+        f('#wizard_select_navigation').click()
+        f('.ic-wizard-box__message-button a').click()
+
+        # Modify Naviagtion
+        f('#navigation_tab').click()
+        f('.navitem.enabled.modules .al-trigger.al-trigger-gray').click()
+        f('.navitem.enabled.modules .admin-links .disable_nav_item_link').click()
+        f('#tab-navigation .btn').click()
+
+        go_to_checklist
+        check_if_item_complete('select_navigation')
+      end
+
+      it "should complete 'Add Course Calendar Events' checklist item" do
+        course_with_teacher_logged_in
+        get "/courses/#{@course.id}"
+
+        # Navigate to Calendar tab
+        go_to_checklist
+        f('#wizard_course_calendar').click()
+        f('.ic-wizard-box__message-button a').click()
+
+        # Add Event
+        f("#create_new_event_link").click()
+        wait_for_ajaximations
+        replace_content(f('#edit_calendar_event_form #calendar_event_title'), "Event")
+        f("#edit_calendar_event_form button.event_button").click()
+        wait_for_ajaximations
+
+        go_to_checklist
+        check_if_item_complete('course_calendar')
+      end
+
+      it "should complete 'Publish the Course' checklist item" do
+        course_with_teacher_logged_in
+        get "/courses/#{@course.id}"
+
+        # Publish from Checklist
+        go_to_checklist
+        f('#wizard_publish_course').click()
+        f('.ic-wizard-box__message-button button').click()
+
+        go_to_checklist
+        check_if_item_complete('publish_course')
+      end
     end
 
     it "should correctly update the course quota" do