Forgot password now matches email without case consideration. Fixes #8861

Updates forgot_password to use newer (and already existing) named scopes
for better searching. Uses a case-insensitive search by email that is
supported on multiple databases. Additional minor refactor to clean up code
and only do the search if an email is given. Blanks don't count anymore.

Testing Notes:
* Create a user with a CommunicationChannel email that has mixed case like
  "Tom.Thumb@example.com"
* Doing a "forgot password" from login should now match and generate an email.

Change-Id: I1bec847fbae8b43e949210b010aa2cfad438ce55
Reviewed-on: https://gerrit.instructure.com/11193
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Joe Tanner <joe@instructure.com>

Author: Mark Ericksen

app/controllers/pseudonyms_controller.rb

@@ -59,15 +59,17 @@ def index
   def forgot_password
     email = params[:pseudonym_session][:unique_id_forgot] if params[:pseudonym_session]
     @ccs = []
-    @ccs = CommunicationChannel.find_all_by_path_and_path_type_and_workflow_state(email, 'email', 'active')
-    if @ccs.empty?
-      @ccs += CommunicationChannel.find_all_by_path_and_path_type(email, 'email') if email and !email.empty?
-    end
-    if @domain_root_account && email && !email.empty?
-      @domain_root_account.pseudonyms.active.custom_find_by_unique_id(email, :all).each do |p|
-        cc = p.communication_channel if p.communication_channel && p.user
-        cc ||= p.user.communication_channel rescue nil
-        @ccs << cc
+    if email.present?
+      @ccs = CommunicationChannel.email.by_path(email).active.all
+      if @ccs.empty?
+        @ccs += CommunicationChannel.email.by_path(email).all
+      end
+      if @domain_root_account
+        @domain_root_account.pseudonyms.active.custom_find_by_unique_id(email, :all).each do |p|
+          cc = p.communication_channel if p.communication_channel && p.user
+          cc ||= p.user.communication_channel rescue nil
+          @ccs << cc
+        end
       end
     end
     @ccs = @ccs.flatten.compact.uniq.select do |cc|

spec/controllers/pseudonyms_controller_spec.rb

@@ -62,6 +62,16 @@
         assigns[:ccs].detect{|cc| cc == @cc}.messages_sent.should_not be_empty
       end
 
+      it "should use case insensitive match for CommunicationChannel email" do
+        # Setup user with communication channel that has mixed case email
+        user_with_pseudonym
+        @cc = communication_channel_model(:user_id => @user.id, :workflow_state => 'active', :path => 'Victoria.Silvstedt@example.com')
+        get 'forgot_password', :pseudonym_session => {:unique_id_forgot => 'victoria.silvstedt@example.com'}
+        response.should be_redirect
+        assigns[:ccs].should include(@cc)
+        assigns[:ccs].detect{|cc| cc == @cc}.messages_sent.should_not be_nil
+        assigns[:ccs].detect{|cc| cc == @cc}.messages_sent.should_not be_empty
+      end
       it "should send password-change email case insensitively" do
         user_with_pseudonym(:username => 'user1@example.com')
         get 'forgot_password', :pseudonym_session => {:unique_id_forgot => 'USER1@EXAMPLE.COM'}