Skip to content

Commit 75fff14

Browse files
committed
fix remove all authentication cofirmation alert
fixes: CNVS-33689 test plan: • add some identity providers to your root account via accounts/self/authentication_providers • click on 'Remove All Authentication' • verify alert prompt: 'Are you sure? Users may not be able to log in if this is removed.' • added identity providers are successfully removed besides default canvas auth Change-Id: Iee924f46f60a4937680a97a7aa00ec0f21fdf426 Reviewed-on: https://gerrit.instructure.com/96859 Tested-by: Jenkins Reviewed-by: Cody Cutrer <cody@instructure.com> Reviewed-by: Ryan Shaw <ryan@instructure.com> QA-Review: Jeremy Putnam <jeremyp@instructure.com> Product-Review: August Thornton <august@instructure.com>
1 parent 32b574f commit 75fff14

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

app/views/account_authorization_configs/index.html.erb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@
1818

1919
<% if @presenter.auth? %>
2020
<%= link_to(account_remove_all_authentication_providers_url(@account),
21-
confirm: t(:delete_auth_confirmation, "Are you sure? Users may not be able to log in if this is removed."),
21+
data: { confirm: t(:delete_auth_confirmation,
22+
'Are you sure? Users may not be able to log in if this is removed.') },
2223
method: :delete,
2324
class: "delete_auth_link btn icon-trash button-sidebar-wide") do %>
2425
<%= t(:delete_auth_link, "Remove All Authentication") %>

spec/selenium/admin/account_admin_auth_configs_spec.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,8 @@
9898
expect(Account.default.authentication_providers.active.count).to eq 3
9999
expect_new_page_load(true) do
100100
f('.delete_auth_link').click
101+
expect(alert_present?).to be_truthy
102+
accept_alert
101103
end
102104
expect(Account.default.authentication_providers.active.count).to eq 1
103105
expect(Account.default.authentication_providers.count).to eq 4

0 commit comments

Comments
 (0)