Commit 774ff31
committed
Add eslint to Canvas
Rollout plan for this:
1. Add necessary files and plugins to Canvas (this commit)
- This will do nothing for many people, but those with eslint
plugins in their editors will now start seeing linting stuff
show up properly
- These users can gradually add/remove rules as they see fit or
where it makes sense. The default rule set is from Airbnb with
a few minor modifications to make things less difficult with the
current codebase.
2. Turn on warnings in the CI system (this commit + 1-2 months)
- This would only apply to the diffs of new code
- This will allow additional feedback from developers that don't
already lint locally. Rules can be adjusted as seen fit.
3. Turn on failures in the CI system (this commit + 3-4 months)
- Again this will be only for changed code, but at this point will
start failing builds that don't follow the standards.
- Changes to the rules can still be made here, but should be less
frequent than those made in the previous 2 steps.
closes CNVS-32987
Test Plan:
- Running eslint locally works
- Editors pick up linting errors when configured properly
Change-Id: I93b7da735b96b472857120418c3c271a9ed6d429
Reviewed-on: https://gerrit.instructure.com/93969
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>1 parent 4fe2092 commit 774ff31
3 files changed
Lines changed: 47 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| |||
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
32 | 38 | | |
33 | 39 | | |
34 | 40 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
0 commit comments