spec: discussions intermittent failure

      "should edit a side comment"

Change-Id: I491e32a15ad209fff8627f844ad932846abe2b1e
Reviewed-on: https://gerrit.instructure.com/13658
Reviewed-by: Bryan Madsen <bryan@instructure.com>
Tested-by: Bryan Madsen <bryan@instructure.com>

Author: smeredith0506

spec/selenium/discussions_spec.rb

@@ -338,7 +338,6 @@ def toggle(state)
         entry = @topic.discussion_entries.create!(:user => @student, :message => "new side comment from student", :parent_entry => @entry)
         get "/courses/#{@course.id}/discussion_topics/#{@topic.id}"
         wait_for_ajax_requests
-
         delete_entry(entry)
       end
 
@@ -347,7 +346,6 @@ def toggle(state)
         text = "new side comment from student"
         entry = @topic.discussion_entries.create!(:user => @student, :message => "new side comment from student", :parent_entry => @entry)
         get "/courses/#{@course.id}/discussion_topics/#{@topic.id}"
-        wait_for_ajax_requests
         wait_for_js
         validate_entry_text(entry, text)
         edit_entry(entry, edit_text)

spec/selenium/helpers/discussions_common.rb

@@ -68,8 +68,10 @@ def get_all_replies
   end
 
   def validate_entry_text(discussion_entry, text)
-    li_selector = %([data-id$="#{discussion_entry.id}"])
-    keep_trying_until { fj(li_selector).should include_text(text) }
+    keep_trying_until do
+      li_selector = %([data-id$="#{discussion_entry.id}"])
+      fj(li_selector).should include_text(text)
+    end
   end
 
   def click_entry_option(discussion_entry, menu_item_selector)