allow any url for mathquill fixes #8038

Change-Id: I41b5296fdd0d375fa291bdbebdcfd63b4e79b9d3
Reviewed-on: https://gerrit.instructure.com/9881
Reviewed-by: Jon Jensen <jon@instructure.com>
Tested-by: Hudson <hudson@instructure.com>

Author: Ryan Florence

app/controllers/equation_images_controller.rb

@@ -2,7 +2,10 @@ class EquationImagesController < ApplicationController
 
   # Facade to codecogs API so we retain control
   def show
+    # TODO: escape id here, and stop double escaping it in
+    # public/javascripts/tinymce/jscripts/tiny_mce/plugins/instructure_equation/editor_plugin.js
+    # this will require a corresponding data migration to fix
     redirect_to 'http://latex.codecogs.com/gif.latex?' + params[:id]
   end
 
-end
+end

config/routes.rb

@@ -833,7 +833,7 @@ def et_routes(route_object, context)
     lti.post "tools/:tool_id/ext_grade_passback", :controller => :lti_api, :action => :legacy_grade_passback, :path_name => "blti_legacy_grade_passback_api"
   end
 
-  map.resources :equation_images, :only => :show
+  map.equation_images 'equation_images/:id', :controller => :equation_images, :action => :show, :id => /.+/
 
   # assignments at the top level (without a context) -- we have some specs that
   # assert these routes exist, but just 404. I'm not sure we ever actually want

spec/selenium/wiki_and_tiny_spec.rb

@@ -143,7 +143,7 @@
   end
 
   it "should add an equation to the rce by using the equation editor" do
-    equation_text = '\\text{yay math stuff:}\\:\\frac{d}{dx}\\sqrt{x}=\\frac{d}{dx}x^{\\frac{1}{2}}=\\frac{1}{2}x^{-\\frac{1}{2}}=\\frac{1}{2\\sqrt{x}}'
+    equation_text = '\\text{yay math stuff:}\\:\\frac{d}{dx}\\sqrt{x}=\\frac{d}{dx}x^{\\frac{1}{2}}=\\frac{1}{2}x^{-\\frac{1}{2}}=\\frac{1}{2\\sqrt{x}}\\text{that. is. so. cool.}'
 
     get "/courses/#{@course.id}/wiki"
 
@@ -175,10 +175,22 @@
     textarea.send_keys "=1/2"
     f('.mathquill-editor .mathquill-toolbar a[title="\\\\sqrt"]').click
     textarea.send_keys "x"
+    textarea.send_keys :arrow_right
+    textarea.send_keys :arrow_right
+    textarea.send_keys "\\text that. is. so. cool."
     driver.find_element(:id, 'instructure_equation_prompt_form').submit
     wait_for_ajax_requests
     in_frame "wiki_page_body_ifr" do
-      keep_trying_until { driver.find_element(:css, '.equation_image').attribute('title').should == equation_text }
+      keep_trying_until { f('.equation_image').attribute('title').should == equation_text }
+
+      # currently there's an issue where the equation is double-escaped in the
+      # src, though it's correct after the redirect to codecogs. here we just
+      # want to confirm we redirect correctly. so when that bug is fixed, this
+      # spec should still pass.
+      src = f('.equation_image').attribute('src')
+      response = Net::HTTP.get_response(URI.parse(src))
+      response.code.should eql "302"
+      response.header['location'].should include URI.encode(equation_text, Regexp.new("[^#{URI::PATTERN::UNRESERVED}]"))
     end
   end