Skip to content

Commit 84bfbd6

Browse files
author
Vincent Gonzalez
committed
created new styling for CNVS-15493
new colors are based on $canvas-neutral contrast for context on quizzes tab. can be viewed at '/quizzes' rewrote quiz list text and icons to have single darken function. also, one less selector! regular: #808080 on #fff :: 3.95:1 high contrast: #6d6d6d on #fff :: 5.17:1 Test plan: - Navigated to quizzes tab. If there are no quizzes create one. - Verify contrast of publish icon, and 'pts' and 'question' text has been updated. You can verify the color contrast using http://webaim.org/resources/contrastchecker/ - After verifying enable high contrast. - Repeat previous tests to verify high contrast color ratios. Change-Id: I83ec5baf03d0264efcf0d7110c7f2be240f15b83 Reviewed-on: https://gerrit.instructure.com/41679 Reviewed-by: Chris Hart <chart@instructure.com> Tested-by: Jenkins <jenkins@instructure.com> QA-Review: Anna Koalenz <akoalenz@instructure.com> Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
1 parent 5d0008f commit 84bfbd6

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

app/stylesheets/components/_item-groups.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,6 @@ is for items that are not draggable.
233233
}
234234

235235
.ellipses {
236-
color: #7c7c7c;
237236
overflow: hidden;
238237
white-space: nowrap;
239238
text-overflow: ellipsis;
@@ -301,6 +300,7 @@ is for items that are not draggable.
301300

302301
.publish-icon {
303302
margin-right: 22px;
303+
304304

305305
i[class*=icon-]:before,
306306
i[class^=icon-]:before {
@@ -329,4 +329,4 @@ is for items that are not draggable.
329329
.ig-text {
330330
color: #3d454c;
331331
font-size: 15px;
332-
}
332+
}

app/stylesheets/pages/quizzes/_quizzes.sass

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,11 @@ $selectedBorderColor: #31b5ff
3030
li.quiz
3131
cursor: pointer
3232

33-
.ellipses
34-
color: #7c7c7c
33+
.ellipses, i[class^=icon-]:not(.icon-publish)
34+
@if $use_high_contrast
35+
color: $canvas-neutral
36+
@else
37+
color: darken($canvas-neutral, 40)
3538

3639
.ig-title
3740
right: 554px

0 commit comments

Comments
 (0)