Skip to content

Commit 8566404

Browse files
committed
fix coffeescript syntax for future versions
CoffeeScript source is currently pinned to 1.6.2 but these two files will have syntax errors if/when coffeescript is upgraded to >=1.7.0 To demonstrate the syntax errors, temporarily modify `Gemfile.d/development_and_test.rb` to use `1.7.0` for `coffee-script-source`, bundle update, and recompile assets. These are the only 2 errors and will work with coffeescript 1.10 as well. Test Plan - There should be no change. I did not see if this code is currently covered by a test case. This is a low-priority PR. I needed to track down these two problems to use a gem which required a higher version of coffee-script.
1 parent 149b91b commit 8566404

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

app/coffeescripts/jquery/mediaComment.coffee

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -198,9 +198,9 @@ define [
198198
close: ->
199199
$mediaPlayer = $this.data('mediaelementplayer')
200200
$mediaPlayer.pause() if $mediaPlayer
201-
open: (ev) -> $(ev.currentTarget).parent()
202-
.find('.ui-dialog-titlebar-close')
203-
.focus()
201+
open: (ev) -> $(ev.currentTarget).parent().
202+
find('.ui-dialog-titlebar-close').
203+
focus()
204204
205205
# Populate dialog box with a video
206206
$dialog.disableWhileLoading getSourcesAndTracks(id).done (sourcesAndTracks) ->

app/coffeescripts/util/processMigrationItemSelections.coffee

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ define ->
3030
allSelections.push matchData[1] if value is "1"
3131
newData[key] = value
3232

33-
for own allSelection in allSelections
33+
for allSelection in allSelections
3434
delete newData.items_to_copy[allSelection]
3535

3636
newData

0 commit comments

Comments
 (0)