backbone 1.0

breaking changes:
* parse expects options, not xhr, as second arg
* no more Backbone.wrapError
* Collection::fetch doesn't call reset by default anymore (though for
  compatibility, PaginatedCollection still does it on the first fetch)
* url is an optionProperty

test plan:
1. canvas should work :)

Change-Id: Ic68f8c076316efe17474ce25c4191ae0ad01535e
Reviewed-on: https://gerrit.instructure.com/22679
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Braden Anderson <banderson@instructure.com>
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Product-Review: Marc LeGendre <marc@instructure.com>
QA-Review: Marc LeGendre <marc@instructure.com>

Author: jenseng

app/coffeescripts/backbone-ext/Collection.coffee

@@ -176,8 +176,8 @@ define [
     #     author:
     #       foreignKey: 'person_id'
     #
-    parse: (response, xhr) ->
-      return super unless response.meta?
+    parse: (response, options) ->
+      return super unless response?.meta?
 
       primaryCollection = response[response.meta.primaryCollection]
       _.each (@sideLoad || {}), (meta, relation) ->
@@ -200,4 +200,4 @@ define [
             item[relation] = related
             delete item[foreignKey]
 
-      super primaryCollection, xhr
+      super primaryCollection, options

app/coffeescripts/bundles/page_views.coffee

@@ -28,7 +28,7 @@ require [
   pageViews = new PageViewCollection
   pageViews.url = "/api/v1/users/#{userId}/page_views"
 
-  fetchOptions = add: false
+  fetchOptions = reset: true
 
   pageViewsView = new PageViewView
     collection: pageViews

app/coffeescripts/calendar/CalendarEvent.coffee

@@ -40,7 +40,7 @@ define [
       success = options.success
       delete options.success
 
-      error = Backbone.wrapError(options.error, model, options)
+      error = options.error ? ->
       delete options.error
 
       if @get('id')
@@ -52,7 +52,7 @@ define [
         [syncResp, syncStatus, syncXhr] = syncArgs
         [sectionsResp] = sectionArgs
         calEventData = CalendarEvent.mergeSectionsIntoCalendarEvent(syncResp, _.sortBy(sectionsResp, 'id'))
-        return false unless model.set(model.parse(calEventData, syncXhr), options)
+        return false unless model.set(model.parse(calEventData), options)
         success?(model, calEventData)
 
       $.when(syncDfd, sectionsDfd)

app/coffeescripts/collections/FilesCollection.coffee

@@ -28,12 +28,12 @@ define [
       options.data = _.extend content_types: @parentFolder.contentTypes, options.data || {}
       super options
 
-    parse: (response, xhr) ->
+    parse: (response) ->
       if response
         previewUrl = @parentFolder.previewUrl()
         _.each response, (file) ->
           file.preview_url = if previewUrl
             previewUrl.replace('{{id}}', file.id.toString())
           else
             file.url
-      super response, xhr
+      super

app/coffeescripts/collections/FoldersCollection.coffee

@@ -28,8 +28,8 @@ define [
 
     model: Folder
 
-    parse: (response, xhr) ->
+    parse: (response) ->
       if response
         _.each response, (folder) =>
           folder.contentTypes = @parentFolder.contentTypes
-      super response, xhr
+      super

app/coffeescripts/collections/OutcomeGroupCollection.coffee

@@ -25,7 +25,7 @@ define [
   class OutcomeGroupCollection extends PaginatedCollection
     model: OutcomeGroup
 
-    parse: (response, xhr) ->
-      super response, xhr
+    parse: (response) ->
+      super
       _.reject response, (groupObj) ->
         groupObj.id is ENV.COMMON_CORE_GROUP_ID

app/coffeescripts/collections/PaginatedCollection.coffee

@@ -36,31 +36,30 @@ define [
 
     perPageRegex: /\per_page=(\d+)/
 
-    ##
-    # have to do this stuff here or else 'reset' and other events are fired
-    # before _setStateAfterFetch has happened, so the state is just barely off
-    parse: (response, xhr) ->
-      @_urlCache ?= []
-      @_lastFetchOptions ?= {}
-      @_setStateAfterFetch xhr, @_lastFetchOptions
-      @_urlCache.push @_lastFetchOptions.url unless @_lastFetchOptions.url in @_urlCache
-      delete @_lastFetchOptions
-      super
-
     ##
     # options.page: 'next', 'prev', 'first', 'last', 'top', 'bottom'
     fetch: (options = {}) ->
       exclusionFlag = "fetching#{capitalize options.page}Page"
       @[exclusionFlag] = true
       if options.page?
         options.url = @urls[options.page] if @urls?
-        options.add = true unless options.add?
+        options.remove = false unless options.remove?
         # API keeps params intact, kill data here to avoid appending in super
         options.data = ''
-      @_lastFetchOptions = options
+      else
+        # we want the first fetch to reset (since a lot of existing code wants a reset event)
+        options.reset = true unless options.reset?
       @trigger 'beforeFetch', this, options
       @trigger "beforeFetch:#{options.page}", this, options if options.page?
-      super(options).done (response, text, xhr) =>
+
+      # have to do this stuff here or else 'reset' and other events are fired
+      # before _setStateAfterFetch has happened, so the state is just barely off
+      xhr = null
+      options.dataFilter = (data) =>
+        @_setStateAfterFetch(xhr, options)
+        data
+
+      xhr = super(options).done (response, text, xhr) =>
         @[exclusionFlag] = false
         @trigger 'fetch', this, response, options
         @trigger "fetch:#{options.page}", this, response, options if options.page?
@@ -72,8 +71,10 @@ define [
     canFetch: (page) ->
       @urls? and @urls[page]?
 
-    _setStateAfterFetch: (xhr, options={}) =>
+    _setStateAfterFetch: (xhr, options) =>
+      @_urlCache ?= []
       urlIsNotCached = options.url not in @_urlCache
+      @_urlCache.push options.url if not urlIsNotCached
       firstRequest = !@urls?
       setBottom = firstRequest or (options.page in ['next', 'bottom'] and urlIsNotCached)
       setTop = firstRequest or (options.page in ['prev', 'top'] and urlIsNotCached)

app/coffeescripts/collections/SyllabusAppointmentGroupsCollection.coffee

@@ -29,7 +29,7 @@ define [
 
     fetch: (options) ->
       options ?= {}
-      options['add'] ?= true
+      options.remove ?= false
 
       options['data'] ?= {}
       options['data']['scope'] = @scope

app/coffeescripts/collections/SyllabusCalendarEventsCollection.coffee

@@ -29,7 +29,7 @@ define [
 
     fetch: (options) ->
       options ?= {}
-      options['add'] ?= true
+      options.remove ?= false
 
       options['data'] ?= {}
       options['data']['type'] = @type

app/coffeescripts/models/Outcome.coffee

@@ -32,7 +32,7 @@ define [
       !@has('description')
 
     # overriding to work with both outcome and outcome link responses
-    parse: (resp, xhr) ->
+    parse: (resp) ->
       if resp.outcome # it's an outcome link
         @outcomeLink = resp
         @outcomeGroup = resp.outcome_group