Spec: remove duplicate appointment group notification specs

Remove duplicated specs, add test rail ids, and fix one spec that
was testing the wrong action.

Test plan:
Run specs, review organization

Change-Id: I4e8e4c989e92d1b0ccf6a0abd7383742787b3834
Reviewed-on: https://gerrit.instructure.com/67819
Tested-by: Jenkins
Reviewed-by: Derek Hansen <dhansen@instructure.com>
Product-Review: Derek Hansen <dhansen@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>

Author: beckesea

spec/models/appointment_group_spec.rb

@@ -345,20 +345,20 @@
       @ag = AppointmentGroup.create!(:title => "test", :contexts => [@course], :new_appointments => [['2012-01-01 13:00:00', '2012-01-01 14:00:00']])
     end
 
-    it "should notify all participants when publishing" do
+    it "should notify all participants when publishing", priority: "1", test_id: 186566 do
       @ag.publish!
       expect(@ag.messages_sent).to be_include("Appointment Group Published")
       expect(@ag.messages_sent["Appointment Group Published"].map(&:user_id).sort.uniq).to eql [@student.id]
     end
 
-    it "should notify all participants when adding appointments" do
+    it "should notify all participants when adding appointments", priority: "1", test_id: 193138 do
       @ag.publish!
       @ag.update_attributes(:new_appointments => [['2012-01-01 12:00:00', '2012-01-01 13:00:00']])
       expect(@ag.messages_sent).to be_include("Appointment Group Updated")
       expect(@ag.messages_sent["Appointment Group Updated"].map(&:user_id).sort.uniq).to eql [@student.id]
     end
 
-    it "should notify all participants when deleting" do
+    it "should notify all participants when deleting", priority: "1", test_id: 193137 do
       @ag.publish!
       @ag.cancel_reason = "just because"
       @ag.destroy

spec/models/calendar_event_spec.rb

@@ -420,7 +420,7 @@
         end
       end
 
-      it "should notify all participants except the person reserving" do
+      it "should notify all participants except the person reserving", priority: "1", test_id: 193149 do
         reservation = @appointment2.reserve_for(@group, @student1)
         expect(Message.where(notification_id: BroadcastPolicy.notification_finder.by_name("Appointment Reserved For User"), user_id: [@student1, @student2]).pluck(:user_id)).to eq [@student2.id]
       end
@@ -432,28 +432,29 @@
         expect(Message.where(notification_id: BroadcastPolicy.notification_finder.by_name("Appointment Deleted For User"), user_id: [@student1, @student2]).pluck(:user_id)).to eq [@student2.id]
       end
 
-      it "should notify participants if teacher deletes the appointment time slot" do
+      it "should notify participants if teacher deletes the appointment time slot", priority: "1", test_id: 193148 do
         reservation = @appointment2.reserve_for(@group, @student1)
         @appointment2.updating_user = @teacher
         @appointment2.destroy
         expect(Message.where(notification_id: BroadcastPolicy.notification_finder.by_name("Appointment Deleted For User"), user_id: [@student1, @student2]).pluck(:user_id).sort).to eq [@student1.id, @student2.id]
       end
 
-      it "should notify all participants when the the time slot is canceled" do
+      it "should notify all participants when the the time slot is canceled", priority: "1", test_id: 502005 do
         reservation = @appointment2.reserve_for(@group, @student1)
         @appointment2.updating_user = @teacher
-        @appointment2.destroy
-        expect(@appointment2.messages_sent).to be_empty
+        user_evt = CalendarEvent.where(context_type: 'Group').first
+        user_evt.updating_user = @teacher
+        user_evt.destroy
         expect(Message.where(notification_id: BroadcastPolicy.notification_finder.by_name("Appointment Deleted For User"), user_id: [@student1, @student2]).pluck(:user_id).sort).to eq [@student1.id, @student2.id]
       end
 
-      it "should notify admins when a user reserves" do
+      it "should notify admins when a user reserves", priority: "1", test_id: 193144 do
         reservation = @appointment.reserve_for(@user, @user)
         expect(reservation.messages_sent).to be_include("Appointment Reserved By User")
         expect(reservation.messages_sent["Appointment Reserved By User"].map(&:user_id).sort.uniq).to eql @course.instructors.map(&:id).sort
       end
 
-      it "should notify admins when a user cancels" do
+      it "should notify admins when a user cancels", priority: "1", test_id: 193147 do
         reservation = @appointment.reserve_for(@student1, @student1)
         reservation.updating_user = @student1
         reservation.destroy

spec/selenium/notifications_spec.rb

@@ -20,112 +20,6 @@
       site_admin_logged_in
     end
 
-    context "with all notifications loaded" do
-      before :once do
-        NotificationsCommon.load_all_notifications
-      end
-
-      context "with appointment group created" do
-        before(:each) do
-          create_appointment_group
-          @appt_grp = AppointmentGroup.last
-        end
-
-        it "should send a notification that appointment group is available", priority: "1", test_id: 186566 do
-          expected_notification = 'Appointment Group Published'
-
-          expect(Message.last.notification_name).to eql(expected_notification)
-          expect(Message.last.subject).to include_text("Appointment \"#{@appt_grp.title}\" is available for signup")
-          expect(Message.last.to).to eql(@student.email)
-        end
-
-        it "should send a notification when appointment group is updated", priority: "1", test_id: 193138 do
-          expected_notification = 'Appointment Group Updated'
-          @appt_grp.update_attributes(new_appointments: [[Time.zone.today + 2.days, Time.zone.today + 3.days]])
-
-          expect(Message.last.notification_name).to eql(expected_notification)
-          expect(Message.last.subject).to include_text("Appointment \"#{@appt_grp.title}\" has been updated")
-          expect(Message.last.to).to eql(@student.email)
-        end
-
-        it "should send a notification when appointment group is deleted", priority: "1", test_id: 193137 do
-          expected_notification = 'Appointment Group Deleted'
-          @appt_grp.destroy
-
-          expect(Message.last.notification_name).to eql(expected_notification)
-          expect(Message.last.subject).to include_text("Appointments for #{@appt_grp.title} have been canceled")
-          expect(Message.last.to).to eql(@student.email)
-        end
-
-        it "should notify teacher when appointment is reserved by user", priority: "1", test_id: 193144 do
-          skip "This spec is blocked by CNVS-24671"
-
-          # TODO: Verify this is the correct Notification name
-          expected_notification = 'Appointment Reserved By User'
-          appt_grp_evt = @appt_grp.appointments[0]
-          appt_grp_evt.reserve_for(@student, @student)
-
-          expect(Message.last.notification_name).to eql(expected_notification)
-
-          # TODO: Update the text for the notification
-          expect(Message.last.subject).to include_text("Appointments for #{@appt_grp.title} have been canceled")
-          expect(Message.last.to).to eql(@teacher.email)
-        end
-
-        it "should notify student when appointment scheduled on their behalf", priority: "1", test_id: 193149 do
-          expected_notification = 'Appointment Reserved For User'
-          appt_grp_evt = @appt_grp.appointments[0]
-          appt_grp_evt.reserve_for(@student, @teacher)
-
-          expect(Message.last.notification_name).to eql(expected_notification)
-          expect(Message.last.subject).to include_text("You have been signed up for \"#{@appt_grp.title}\"")
-          expect(Message.last.to).to eql(@student.email)
-        end
-
-        it "should notify teacher when student deletes appointment", priority: "1", test_id: 193147 do
-          skip "This spec is blocked by CNVS-24671"
-
-          # TODO: Verify this is the correct Notification name
-          expected_notification = 'Appointment Deleted By User'
-          appt_grp_evt = @appt_grp.appointments[0]
-          appt_grp_evt.reserve_for(@student, @student)
-          appt_grp_evt.updating_user = @student
-          appt_grp_evt.destroy
-
-          expect(Message.last.notification_name).to eql(expected_notification)
-
-          # TODO: Update the text for the notification
-          expect(Message.last.subject).to include_text("Your time slot for #{@appt_grp.title} has been canceled")
-          expect(Message.last.to).to eql(@student.email)
-        end
-
-        it "should notify student when appointment is deleted", priority: "1", test_id: 193148 do
-          expected_notification = 'Appointment Deleted For User'
-          appt_grp_evt = @appt_grp.appointments[0]
-          appt_grp_evt.reserve_for(@student, @student)
-          appt_grp_evt.updating_user = @teacher
-          appt_grp_evt.destroy
-
-          expect(Message.last.notification_name).to eql(expected_notification)
-          expect(Message.last.subject).to include_text("Your time slot for #{@appt_grp.title} has been canceled")
-          expect(Message.last.to).to eql(@student.email)
-        end
-
-        it "should notify student when appointment is un-reserved", priority: "1", test_id: 502005 do
-          expected_notification = 'Appointment Deleted For User'
-          appt_grp_evt = @appt_grp.appointments[0]
-          appt_grp_evt.reserve_for(@student, @student)
-          user_evt = CalendarEvent.where(context_type: 'User').first
-          user_evt.updating_user = @teacher
-          user_evt.destroy
-
-          expect(Message.last.notification_name).to eql(expected_notification)
-          expect(Message.last.subject).to include_text("Your time slot for #{@appt_grp.title} has been canceled")
-          expect(Message.last.to).to eql(@student.email)
-        end
-      end
-    end
-
     context "Assignment notifications" do
       before :each do
         setup_notification(@teacher, name: 'Assignment Submitted', sms: true)