Commit 93eb2e2
committed
pass explicit submission_type for assignment quick add
turns out, according to the mozilla spec, some browsers will fall back
to the text of an option if the value is not specified. so just to be
clear, we'll explicitly specify 'none' as our submission type for
assignment quick add
fixes CNVS-16548
test plan:
- in IE10, go to the assignment index page
- if an assignment group doesn't already exist, create one
- click the '+' icon to add an assignment to that group
- leave type specified as "Assignment"
- hit save
- it should work
- also make sure other types still work
Change-Id: I06b810a4824535066962c2f915f6edd4c1ea9f56
Reviewed-on: https://gerrit.instructure.com/48838
Tested-by: Jenkins
Reviewed-by: Benjamin Porter <bporter@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>1 parent 3b6f8ba commit 93eb2e2
2 files changed
Lines changed: 6 additions & 1 deletion
File tree
- app/views/jst/assignments
- spec/coffeescripts/views/assignments
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
234 | 234 | | |
235 | 235 | | |
236 | 236 | | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
0 commit comments