remove unnecessary zIndex from Modals/PopoverMenus

Previously zIndex values were necessary for instructure-ui
components to render correctly. This problem was solved in a recent
release of instructure-ui so this workaround is no longer needed.

Change-Id: I1bf21b1dde8ffe93109b2296e5acf03cdc2e011e
Reviewed-on: https://gerrit.instructure.com/107550
Tested-by: Jenkins
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Derek Bender <djbender@instructure.com>
QA-Review: Derek Bender <djbender@instructure.com>

Author: djbender

app/jsx/add_people/components/add_people.js

@@ -278,7 +278,6 @@ import APIError from './api_error'
           shouldCloseOnOverlayClick={false}
           size="medium"
           tabindex="-1"
-          zIndex="9999"
         >
           <ModalHeader>
             <Heading tabIndex="-1">{I18n.t('Add People')}</Heading>

app/jsx/courses/CourseHomeDialog.js

@@ -111,7 +111,6 @@ class CourseHomeDialog extends React.Component {
     return (<Modal
       isOpen={this.props.open}
       transition="fade"
-      zIndex={99999}
       label={I18n.t('Choose Course Home Page')}
       closeButtonLabel={I18n.t("Close")}
       onReady={this.onReady}

app/jsx/eportfolios/MoveToDialog.js

@@ -84,7 +84,7 @@ import Select from 'instructure-ui/lib/components/Select'
           onReady={this.handleReady}
           onRequestClose={this.handleRequestClose}
           onClose={this.handleClose}
-          zIndex='9999'>
+        >
           <ModalHeader>
             <Heading>{ this.props.header }</Heading>
           </ModalHeader>

app/jsx/gradezilla/default_gradebook/components/ActionMenu.js

@@ -180,7 +180,6 @@ import 'compiled/jquery.rails_flash_notifications'
 
       return (
         <PopoverMenu
-          zIndex="9999"
           trigger={
             <Button variant="link">
               <Typography {...buttonTypographyProps}>

app/jsx/gradezilla/default_gradebook/components/AssignmentColumnHeader.js

@@ -195,7 +195,6 @@ class AssignmentColumnHeader extends React.Component {
           contentRef={this.bindOptionsMenuContent}
           focusTriggerOnClose={false}
           trigger={this.renderTrigger()}
-          zIndex="9999"
         >
           <MenuItemGroup label={I18n.t('Sort by')}>
             <MenuItem

app/jsx/gradezilla/default_gradebook/components/AssignmentGroupColumnHeader.js

@@ -88,7 +88,6 @@ class AssignmentGroupColumnHeader extends React.Component {
           contentRef={this.bindOptionsMenuContent}
           focusTriggerOnClose={false}
           trigger={renderTrigger(this.props.assignmentGroup)}
-          zIndex="9999"
         >
           <MenuItemGroup label={I18n.t('Sort by')}>
             <MenuItem

app/jsx/gradezilla/default_gradebook/components/StudentColumnHeader.js

@@ -103,7 +103,6 @@ export default class StudentColumnHeader extends React.Component {
         <PopoverMenu
           contentRef={this.bindOptionsMenuContent}
           focusTriggerOnClose={false}
-          zIndex="9999"
           trigger={
             <span className="Gradebook__ColumnHeaderAction">
               <Typography weight="bold" fontStyle="normal" size="large" color="brand">

app/jsx/gradezilla/default_gradebook/components/TotalGradeColumnHeader.js

@@ -69,7 +69,6 @@ class TotalGradeColumnHeader extends React.Component {
           contentRef={this.bindOptionsMenuContent}
           focusTriggerOnClose={false}
           trigger={renderTrigger()}
-          zIndex="9999"
         >
           <MenuItemGroup label={I18n.t('Sort by')}>
             <MenuItem

app/jsx/outcomes/AddToCourseModal.js

@@ -25,7 +25,6 @@ export default React.createClass({
           size="auto"
           label={I18n.t("Modal Dialog: Add to course")}
           closeButtonLabel={I18n.t("Close")}
-          zIndex="9999"
           ref={this._saveModal}
           onEntering={this._fixFocus}
           onClose={this.props.onClose}

app/jsx/shared/MessageStudents.js

@@ -230,7 +230,6 @@ import Alert from 'instructure-ui/lib/components/Alert'
             label={this.props.title}
             onRequestClose={this.props.onRequestClose}
             closeButtonLabel={I18n.t('Close')}
-            zIndex="9999"
             size='medium'
             onExited={this.props.onExited}
           >