fix changing sort options in speedgrader; fixes #6002

Change-Id: I27e391b764bc5ad1b49cebed269f71b988e62200
Reviewed-on: https://gerrit.instructure.com/6263
Tested-by: Hudson <hudson@instructure.com>
Tested-by: Selenium <selenium@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>

Author: zwily

public/javascripts/speed_grader.js

@@ -332,6 +332,9 @@ I18n.scoped('gradebook', function(I18n) {
         resizable: false,
         width: 400
       });
+      // FF hack - when reloading the page, firefox seems to "remember" the disabled state of this
+      // button. So here we'll manually re-enable it.
+      this.elements.settings.form.find(".submit_button").removeAttr('disabled')
       this.elements.mute.modal.dialog({
         autoOpen: false,
         buttons: buttons,
@@ -349,7 +352,7 @@ I18n.scoped('gradebook', function(I18n) {
 
     submitForm: function(e){
       $.store.userSet('eg_sort_by', $('#eg_sort_by').val());
-      $.store.userSet('eg_hide_student_names', $("#hide_student_names").attr('checked').toString());
+      $.store.userSet('eg_hide_student_names', $("#hide_student_names").prop('checked').toString());
       $(e.target).find(".submit_button").attr('disabled', true).text(I18n.t('buttons.saving_settings', "Saving Settings..."));
       window.location.reload();
       return false;

spec/selenium/speed_grader_spec.rb

@@ -223,4 +223,27 @@ def check_second_student
     find_with_jquery('#students_selectmenu #section-menu').should be_nil # doesn't get inserted into the menu
   end
 
+  it "should be able to change sorting and hide student names" do
+    student_submission
+    
+    get "/courses/#{@course.id}/gradebook/speed_grader?assignment_id=#{@assignment.id}"
+    wait_for_ajaximations
+    
+    driver.find_element(:id, "settings_link").click
+    driver.find_element(:css, 'select#eg_sort_by option[value="submitted_at"]').click
+    driver.find_element(:id, 'hide_student_names').click
+    expect_new_page_load {
+      driver.find_element(:css, '#settings_form .submit_button').click
+    }
+    driver.find_element(:css, '#combo_box_container .ui-selectmenu .ui-selectmenu-item-header').text.should == "Student 1"
+    
+    # make sure it works a second time too
+    driver.find_element(:id, "settings_link").click
+    driver.find_element(:css, 'select#eg_sort_by option[value="alphabetically"]').click
+    expect_new_page_load {
+      driver.find_element(:css, '#settings_form .submit_button').click
+    }
+    driver.find_element(:css, '#combo_box_container .ui-selectmenu .ui-selectmenu-item-header').text.should == "Student 1"
+  end
+
 end