Fixes #5978 - Missing Courses in Menu

We started hiding enrollments where the created_at
and updated_at fields were identical, assuming
it was SIS garbage data.

Turns out we were wrong.  Reverting.

Change-Id: I9a479ea5f1ffde61365ab15aa36975e865be4e74
Reviewed-on: https://gerrit.instructure.com/6241
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>

Author: Ryan Florence

app/models/user.rb

@@ -1913,9 +1913,6 @@ def set_menu_data(enrollment_uuid)
     cached_enrollments = self.cached_current_enrollments(:include_enrollment_uuid => enrollment_uuid)
     cached_enrollments.each do |e|
 
-      # SIS "garbage" data, user auto-enrolled but has never done anything with it
-      next if e.updated_at == e.created_at
-
       next if e.state_based_on_date == :inactive
 
       if e.state_based_on_date == :completed

spec/integration/enrollment_date_restrictions_spec.rb

@@ -33,8 +33,6 @@
     e2.state.should == :active
     e2.state_based_on_date.should == :inactive
 
-    Enrollment.update_all(["created_at = ?", 1.minute.ago]) # need to make created_at and updated_at different
-
     user_session(@student, @pseudonym)
 
     get "/"
@@ -68,8 +66,6 @@
     @group2 = @course2.groups.create(:name => "Group 1")
     @group2.add_user(@student)
 
-    Enrollment.update_all(["created_at = ?", 1.minute.ago]) # need to make created_at and updated_at different
-
     user_session(@student, @pseudonym)
 
     get "/"

spec/integration/navigation_spec.rb

@@ -56,23 +56,4 @@
     get "/"
     response.should be_success
   end
-
-  it "should not show enrollments with identical created_at and updated_at dates (bad SIS data)" do
-    @account = Account.default
-    user_with_pseudonym
-
-    course_with_teacher(:course_name => "Course 1", :user => @user)
-    @enrollment = course_with_teacher(:course_name => "Course 2", :user => @user)
-
-    Enrollment.update_all(["updated_at = ?", @enrollment.created_at], :id => @enrollment.id)
-
-    user_session(@user, @pseudonym)
-
-    get "/"
-    page = Nokogiri::HTML(response.body)
-    list = page.css(".menu-item-drop-column-list li")
-    list.length.should == 2
-  end
 end
-
-