Commit a032030
Colleen Palmer
Alerts do not meet color contrast requirements
closes CNVS-23377
This changes the global alert notifications in the styleguide to meet our
webaim contrast ratios.
Test Plan:
- Go to /styleguide
- Go to Hightlights & Alerts section
- All colors meet our 3:1 contrast ratio
- Turn on High-contrast mode
- Go back to Alert section in styleguide
- All colors meet our 4.5:1 contrast ratio
UI dev notes:
- I moved bootstrap/_alerts css into our component/_alerts file
- Took out _alerts from the custom_bootstrap file
- Took out some commenting cruft in custom_bootstrap
- Took out .alert-block css since on searching it didn't appear to be used
anywhere
- Took out some of the bootstrap styles on the notifications (border,
text-shadow, and margin); then switched out the colors for our variables
- The "info" alert pulls in the primary color variables, so if customized, that
will pull in custom colors
Change-Id: I95b0ebb3cc833fd252160245e176c5dfeeb001b2
Reviewed-on: https://gerrit.instructure.com/64321
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>1 parent 05a9d01 commit a032030
4 files changed
Lines changed: 47 additions & 71 deletions
File tree
- app/stylesheets
- base
- bundles
- components
- vendor/bootstrap
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | 19 | | |
21 | 20 | | |
22 | 21 | | |
23 | 22 | | |
24 | 23 | | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | 24 | | |
29 | 25 | | |
30 | 26 | | |
31 | 27 | | |
32 | 28 | | |
33 | | - | |
34 | | - | |
35 | 29 | | |
36 | 30 | | |
37 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
52 | 98 | | |
53 | 99 | | |
54 | 100 | | |
| |||
This file was deleted.
0 commit comments