Skip to content

Commit a347c85

Browse files
committed
spec: fix two brittle specs
Change-Id: I313670b89c91317754e7a268b1bcadad8e8db434 Reviewed-on: https://gerrit.instructure.com/89383 Tested-by: Jenkins Reviewed-by: Landon Wilkins <lwilkins@instructure.com> Product-Review: Landon Wilkins <lwilkins@instructure.com> QA-Review: Landon Wilkins <lwilkins@instructure.com>
1 parent e504eb1 commit a347c85

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

spec/selenium/helpers/groups_common.rb

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -169,13 +169,11 @@ def manually_set_groupset_limit(member_limit = "2")
169169

170170
def manually_fill_limited_group(member_limit ="2",student_count = 0)
171171
student_count.times do |n|
172-
# Finds all student add buttons and updates the through each iteration
173-
studs = ff('.assign-to-group')
174-
studs.first.click
175-
176-
wait_for_ajaximations
172+
f('.assign-to-group').click
177173
f('.set-group').click
178174
expect(f('.group-summary')).to include_text("#{n+1} / #{member_limit} students")
175+
# make sure the popover is gone; it takes 100ms, and its on('close') -> focus can mess up the next click
176+
expect(f('body')).not_to contain_css('.set-group')
179177
end
180178
expect(f('.show-group-full')).to be_displayed
181179
end

0 commit comments

Comments
 (0)