don't allow sent messages to be archived

test plan:
* sent a message in the inbox
* switch to the "Sent" view
* should not be able to archive the message

closes #CNVS-16426

Change-Id: Ia45c995998ee0bff070af8fb9efd9d3f7e2ee1dd
Reviewed-on: https://gerrit.instructure.com/73863
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>

Author: maneframe

app/coffeescripts/bundles/conversations_new.coffee

@@ -80,6 +80,8 @@ require [
         return @detail.render()
       else if messages.length > 1
         delete @detail.model
+
+        messages[0].set('canArchive', @filters.type != 'sent')
         @detail.onModelChange(messages[0], null)
         @detail.render(batch: true)
         @header.onModelChange(messages[0], null)
@@ -96,6 +98,8 @@ require [
           @detail.$el.disableWhileLoading(@lastFetch)
 
     selectConversation: (model) =>
+      if model
+        model.set('canArchive', @filters.type != 'sent')
       @header.onModelChange(model, null)
       @detail.onModelChange(model, null)
       @detail.render()

app/coffeescripts/views/conversations/InboxHeaderView.coffee

@@ -139,6 +139,10 @@ define [
       @$archiveBtn.attr('title', if archived then @messages['unarchive'] else @messages['archive'])
       @$archiveBtn.find('.screenreader-only')
         .text(if archived then @messages['unarchive_conversation'] else @messages['archive_conversation'])
+      if msg.get('canArchive')
+        @$archiveBtn.removeAttr('disabled')
+      else
+        @$archiveBtn.attr('disabled', true)
       @refreshMenu()
 
     refreshMenu: ->

app/views/jst/conversations/messageDetail.handlebars

@@ -41,10 +41,11 @@
             <li>
               <a href="#" class="forward-btn">{{#t "forward"}}Forward{{/t}}</a>
             </li>
-            <li>
-              <a href="#" class="archive-btn">{{archiveToggleMessage}}</a>
-            </li>
-
+            {{#if canArchive}}
+              <li>
+                <a href="#" class="archive-btn">{{archiveToggleMessage}}</a>
+              </li>
+            {{/if}}
             <li><a href="#" class="star-toggle-btn">{{starToggleMessage}}</a></li>
 
             <li>

spec/selenium/conversations/conversations_spec.rb

@@ -245,6 +245,24 @@
       expect(conversation_elements.size).to eq 1
     end
 
+    it "should not be able to archive a sent message via the admin archive button" do
+      conversations
+
+      select_view('sent')
+      click_message(0)
+      expect(f('#archive-btn').attribute('disabled')).to be_present
+    end
+
+    it "should not be able to archive a sent message via the cog dropdown" do
+      conversations
+
+      select_view('sent')
+      click_message(0)
+      # Clicks the title-level more options gear menu
+      click_more_options(convo:true)
+      expect(f('.archive-btn.ui-corner-all')).to be_nil
+    end
+
     context "in archive view" do
       before do
         @participant.update_attribute(:workflow_state, 'archived')