Commit aeacddd
committed
adds aria text to indicate course selection is required for conversations
fixes CNVS-19240
note: selection is not mandatory for admins
test plan:
- as a non-admin, go to compose message in coversations
- course menu should read "A course selection is required before entering
recipients"
- select a course, course menu should now read name of course
- return menu to 'Select course' default, the required statement should return
- required statement should not read out for admins
Change-Id: I1954ef1d48a77990b3dfa111935be3e788f0d0a5
Reviewed-on: https://gerrit.instructure.com/50959
Tested-by: Jenkins
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Matt Berns <mberns@instructure.com>1 parent b57d3db commit aeacddd
3 files changed
Lines changed: 10 additions & 4 deletions
File tree
- app
- coffeescripts/views/conversations
- views/jst/conversations
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| 55 | + | |
55 | 56 | | |
56 | 57 | | |
57 | 58 | | |
| |||
85 | 86 | | |
86 | 87 | | |
87 | 88 | | |
| 89 | + | |
88 | 90 | | |
89 | 91 | | |
90 | 92 | | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
91 | 98 | | |
92 | 99 | | |
93 | 100 | | |
| |||
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
175 | 175 | | |
176 | 176 | | |
177 | 177 | | |
178 | | - | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
179 | 181 | | |
180 | 182 | | |
181 | 183 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | 35 | | |
39 | 36 | | |
40 | 37 | | |
| |||
0 commit comments