assignment freezing improvements and fixes

Adds an option to not allow already copied assignments from
being copied again

Assignment groups that contain a frozen assignment can not
be deleted

When an assignment is copied that didn't have the flag set
to be frozen, the copied flag isn't set. This allows the
assignment to be locked in the new course, but still edited

Test Plan:
 * In the plugin settings for assignment freezer check the option to not allow assignments to be copied twice
 * Create an assignment and flag it to be frozen
 * Copy the course, verify it is frozen
 * Try to copy the course again as a non-admin - The frozen assignments should not be copied
 * As a teacher try to delete an assignment group for a frozen assignment. The trash can should not appear
 * Copy an assignment that is flagged to be frozen
 * In the new course, you should be able to set the flag and still edit the assignment

closes #8736 #8549 #8537

Change-Id: Ia3f1be4d5c1b6112507338df7e5a49dd76a5ed7f
Reviewed-on: https://gerrit.instructure.com/10995
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>

Author: bracken

app/controllers/assignment_groups_controller.rb

@@ -175,6 +175,15 @@ def update
   def destroy
     @assignment_group = AssignmentGroup.find(params[:id])
     if authorized_action(@assignment_group, @current_user, :delete)
+      if @assignment_group.has_frozen_assignments?(@current_user)
+        @assignment_group.errors.add('workflow_state', t('errors.cannot_delete_group', "You can not delete a group with a locked assignment.", :att_name => 'workflow_state'))
+        respond_to do |format|
+          format.html { redirect_to named_context_url(@context, :context_assignments_url) }
+          format.json { render :json => @assignment_group.errors.to_json, :status => :bad_request }
+        end
+        return
+      end
+
       if params[:move_assignments_to]
         @new_group = @context.assignment_groups.active.find(params[:move_assignments_to])
         order = @new_group.assignments.active.map(&:id)

app/models/assignment.rb

@@ -1526,8 +1526,12 @@ def self.import_from_migration(hash, context, item=nil)
     description += hash[:instructions_in_html] == false ? ImportedHtmlConverter.convert_text(hash[:instructions] || "", context) : ImportedHtmlConverter.convert(hash[:instructions] || "", context)
     description += Attachment.attachment_list_from_migration(context, hash[:attachment_ids])
     item.description = description
-    item.copied = true
-    item.copying = true
+
+    if hash[:freeze_on_copy]
+      item.freeze_on_copy = true
+      item.copied = true
+      item.copying = true
+    end
     if !hash[:submission_types].blank?
       item.submission_types = hash[:submission_types]
     elsif ['discussion_topic'].include?(hash[:submission_format])
@@ -1608,7 +1612,7 @@ def self.import_from_migration(hash, context, item=nil)
     [:all_day, :turnitin_enabled, :peer_reviews_assigned, :peer_reviews,
      :automatic_peer_reviews, :anonymous_peer_reviews,
      :grade_group_students_individually, :allowed_extensions, :min_score,
-     :max_score, :mastery_score, :position, :peer_review_count, :freeze_on_copy
+     :max_score, :mastery_score, :position, :peer_review_count
     ].each do |prop|
       item.send("#{prop}=", hash[prop]) unless hash[prop].nil?
     end
@@ -1729,6 +1733,10 @@ def att_frozen?(att, user=nil)
     false
   end
 
+  def can_copy?(user)
+    !att_frozen?("no_copying", user)
+  end
+
   def frozen_atts_not_altered
     return if self.copying
     FREEZABLE_ATTRIBUTES.each do |att|

app/models/assignment_group.rb

@@ -235,4 +235,15 @@ def self.add_never_drop_assignment(group, assignment)
     group.save
   end
 
+  def has_frozen_assignments?(user)
+    return false unless PluginSetting.settings_for_plugin(:assignment_freezer)
+    return false unless self.active_assignments.length > 0
+
+    self.active_assignments.each do |asmnt|
+      return true if asmnt.frozen_for_user?(user)
+    end
+
+    false
+  end
+
 end

app/models/content_export.rb

@@ -131,7 +131,7 @@ def add_item_to_export(obj)
     selected_content[asset_type][CC::CCHelper.create_key(obj)] = true
   end
 
-  def add_error(user_message, exception_or_info)
+  def add_error(user_message, exception_or_info=nil)
     self.settings[:errors] ||= []
     if exception_or_info.is_a?(Exception)
       er = ErrorReport.log_exception(:course_export, exception_or_info)

app/views/plugins/_assignment_freezer_settings.html.erb

@@ -9,6 +9,12 @@ TEXT
         %></p>
       </td>
     </tr>
+    <tr>
+      <td colspan="2">
+        <%= f.check_box "no_copying", {}, 'yes', 'no' %>
+        <%= f.label "no_copying", t('no_copying_frozen', "Don't allow frozen assignments to be copied.") %>
+      </td>
+    </tr>
     <% Assignment::FREEZABLE_ATTRIBUTES.sort.each do |att| %>
       <tr>
         <td colspan=2><%= f.check_box att, {}, 'yes', 'no' %>

app/views/shared/_assignment_group.html.erb

@@ -30,9 +30,11 @@
         <a href="#" class="edit_group_link no-hover">
           <%= image_tag 'edit.png', :alt => t('alts.edit_group_details', "Edit"), :title => t('links.edit_group_details', "Edit Group Details") %>
         </a>
-        <a href="<%= context_url(@context, :controller => :assignment_groups, :action => :destroy, :id => (assignment_group ? assignment_group.id : "{{ id }}")) %>" class="delete_group_link no-hover">
-          <%= image_tag 'delete.png', :alt => t('alts.delete_assignment_group', "Delete"), :title => t('titles.delete_assignment_group', "Delete Assignment Group") %>
-        </a>
+        <% if !group || !group.has_frozen_assignments?(@current_user) %>
+          <a href="<%= context_url(@context, :controller => :assignment_groups, :action => :destroy, :id => (assignment_group ? assignment_group.id : "{{ id }}")) %>" class="delete_group_link no-hover">
+            <%= image_tag 'delete.png', :alt => t('alts.delete_assignment_group', "Delete"), :title => t('titles.delete_assignment_group', "Delete Assignment Group") %>
+          </a>
+        <% end %>
       </div>
       <div class="clear"></div>
       <div class="more_info" style="min-height: 30px; display: none; padding-left: 30px; font-size: 0.8em;">

lib/cc/assignment_resources.rb

@@ -21,10 +21,17 @@ module AssignmentResources
     def add_assignments
       @course.assignments.active.no_graded_quizzes_or_topics.each do |assignment|
         next unless export_object?(assignment)
+
+        title = assignment.title rescue I18n.t('course_exports.unknown_titles.assignment', "Unknown assignment")
+
+        if !assignment.can_copy?(@user)
+          add_error(I18n.t('course_exports.errors.assignment_is_locked', "The assignment \"%{title}\" could not be copied because it is locked.", :title => title))
+          next
+        end
+
         begin
           add_assignment(assignment)
         rescue
-          title = assignment.title rescue I18n.t('course_exports.unknown_titles.assignment', "Unknown assignment")
           add_error(I18n.t('course_exports.errors.assignment', "The assignment \"%{title}\" failed to export", :title => title), $!)
         end
       end

lib/cc/manifest.rb

@@ -20,7 +20,7 @@ class Manifest
     include CCHelper
 
     attr_accessor :exporter, :weblinks, :basic_ltis
-    delegate :add_error, :set_progress, :export_object?, :for_course_copy, :add_item_to_export, :to => :exporter
+    delegate :add_error, :set_progress, :export_object?, :for_course_copy, :add_item_to_export, :user, :to => :exporter
 
     def initialize(exporter)
       @exporter = exporter

lib/cc/qti/qti_generator.rb

@@ -24,6 +24,7 @@ class QTIGenerator
 
       def initialize(manifest, resources_node, html_exporter)
         @manifest = manifest
+        @user = manifest.user
         @resources_node = resources_node
         @course = manifest.course
         @export_dir = @manifest.export_dir
@@ -55,10 +56,17 @@ def generate
 
         @course.quizzes.active.each do |quiz|
           next unless export_object?(quiz) || export_object?(quiz.assignment)
+
+          title = quiz.title rescue I18n.t('unknown_quiz', "Unknown quiz")
+
+          if quiz.assignment && !quiz.assignment.can_copy?(@user)
+            add_error(I18n.t('course_exports.errors.quiz_is_locked', "The quiz \"%{title}\" could not be copied because it is locked.", :title => title))
+            next
+          end
+
           begin
             generate_quiz(quiz)
           rescue
-            title = quiz.title rescue I18n.t('unknown_quiz', "Unknown quiz")
             add_error(I18n.t('course_exports.errors.quiz', "The quiz \"%{title}\" failed to export", :title => title), $!)
           end
         end

lib/cc/qti/qti_manifest.rb

@@ -21,7 +21,7 @@ class QTIManifest
     include CC::CCHelper
 
     attr_accessor :exporter
-    delegate :add_error, :set_progress, :export_object?, :qti_export?, :course, :to => :exporter
+    delegate :add_error, :set_progress, :export_object?, :qti_export?, :course, :user, :to => :exporter
     delegate :referenced_files, :to => :@html_exporter
 
     def initialize(exporter)