Skip to content

Commit b50ffa9

Browse files
author
Stanley Stuart
committed
ensure selenium specs always wait for requests for context modules
Fixes an issue in context module specs where Selenium wasn't waiting for a link to appear before clicking it. The link it was trying to click is hidden or displayed based on an AJAX request, so it was sometimes unavailable. test plan: - ensure specs pass. Change-Id: Ifc88b07ba18c50bbe1297ad1f65a2278aff4ab1f Reviewed-on: https://gerrit.instructure.com/17740 Reviewed-by: Shawn Meredith <shawn@instructure.com> QA-Review: Shawn Meredith <shawn@instructure.com> Tested-by: Jenkins <jenkins@instructure.com>
1 parent bb514d7 commit b50ffa9

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

spec/selenium/context_modules_spec.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ def create_modules(number_to_create)
4747

4848
get "/courses/#{@course.id}/modules"
4949

50+
# button appears after ajax requests
51+
wait_for_ajaximations
5052
f('.module_progressions_link').click
5153
wait_for_ajaximations
5254
f(".student_list").should be_displayed
@@ -78,6 +80,7 @@ def create_modules(number_to_create)
7880
get "/courses/#{@course.id}/modules"
7981

8082
#opens the student progression link and validates all modules have no information"
83+
wait_for_ajaximations
8184
f('.module_progressions_link').click
8285
wait_for_ajaximations
8386

0 commit comments

Comments
 (0)