fix tooltip times on Syllabus page when user/browser tz don't match

test plan:
 - in your user profile, change your time zone to something
   different from your system time zone
 - hover over due dates and calendar event times and ensure the Course
   and Local times are correct (the Local time should match the
   time in the table)
 - also ensure that events are collated based on the local
   timezone, not the course timezone (that is, an assignment that
   is due on October 20 in the course timezone, but October 21 in
   the local timezone, should appear in a row with left-side
   heading of October 21).

fixes CNVS-17781

Change-Id: I73d5b758807251cb6b8c547534f4c07b44b72b79
Reviewed-on: https://gerrit.instructure.com/46792
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>

Author: jstanley0

app/coffeescripts/handlebars_helpers.coffee

@@ -74,6 +74,11 @@ define [
       new Handlebars.SafeString "<time data-tooltip data-html-tooltip-title='#{htmlEscape timeTitle}' datetime='#{datetime.toISOString()}' #{$.raw('pubdate' if pubdate)}>#{$.friendlyDatetime(fudged)}</time>"
 
 
+    fudge: (datetime) ->
+      $.fudgeDateForProfileTimezone(datetime)
+
+    unfudge: (datetime) ->
+      $.unfudgeDateForProfileTimezone(datetime)
 
     # expects: a Date object or an ISO string
     formattedDate : (datetime, format, {hash: {pubdate}}) ->

app/views/jst/courses/Syllabus.handlebars

@@ -43,12 +43,12 @@
             <td class="dates{{#unless last}} not_last{{/unless}}">
               {{#if start_at}}
                 {{#if due_at}}
-                  due by <span {{contextSensitiveDatetimeTitle due_at}} >{{tTimeHours due_at}}</span>
+                  due by <span {{contextSensitiveDatetimeTitle (unfudge due_at)}} >{{tTimeHours due_at}}</span>
                 {{else}}
-                  <span {{contextSensitiveDatetimeTitle start_at}} >{{tTimeHours start_at}}</span>
+                  <span {{contextSensitiveDatetimeTitle (unfudge start_at)}} >{{tTimeHours start_at}}</span>
                   {{#unless same_time}}
                     to
-                    <span {{contextSensitiveDatetimeTitle end_at}} >
+                    <span {{contextSensitiveDatetimeTitle (unfudge end_at)}} >
                       {{#if same_day}}
                         {{tTimeHours end_at}}
                       {{else}}

spec/coffeescripts/views/SyllabusViewSpec.coffee

@@ -21,6 +21,7 @@ define [
   'underscore'
   'timezone'
   'vendor/timezone/America/Denver'
+  'vendor/timezone/America/New_York'
   'compiled/behaviors/SyllabusBehaviors'
   'compiled/collections/SyllabusCollection'
   'compiled/collections/SyllabusCalendarEventsCollection'
@@ -29,7 +30,7 @@ define [
   'spec/javascripts/compiled/views/SyllabusViewPrerendered'
   'helpers/fakeENV'
   'helpers/jquery.simulate'
-], ($, _, tz, denver, SyllabusBehaviors, SyllabusCollection, SyllabusCalendarEventsCollection, SyllabusAppointmentGroupsCollection, SyllabusView, SyllabusViewPrerendered, fakeENV) ->
+], ($, _, tz, denver, newYork, SyllabusBehaviors, SyllabusCollection, SyllabusCalendarEventsCollection, SyllabusAppointmentGroupsCollection, SyllabusView, SyllabusViewPrerendered, fakeENV) ->
 
   setupServerResponses = ->
     server = sinon.fakeServer.create()
@@ -76,12 +77,13 @@ define [
 
   module 'Syllabus',
     setup: ->
-      fakeENV.setup()
+      fakeENV.setup(TIMEZONE: 'America/Denver', CONTEXT_TIMEZONE: 'America/New_York')
       # Setup stubs/mocks
       @server = setupServerResponses()
 
       @tzSnapshot = tz.snapshot()
       tz.changeZone(denver, 'America/Denver')
+      tz.preload("America/New_York", newYork)
 
       @clock = sinon.useFakeTimers(new Date(2012, 0, 23, 15, 30).getTime())
 
@@ -147,7 +149,7 @@ define [
       SyllabusBehaviors.bindToSyllabus()
 
     renderAssertions: ->
-      expect 15
+      expect 19
 
       # rendering
       syllabus = $('#syllabus')
@@ -193,6 +195,15 @@ define [
       equal expected.length, 2, 'passed events - passed events found'
       deepEqual actual.toArray(), expected.toArray(), 'passed events - events before today marked as passed'
 
+      # context-sensitive datetime titles
+      assignment_ts = $('.events_2012_01_01 .related-assignment_1 .dates > span:nth-child(1)')
+      equal assignment_ts.text(), "10am", "assignment - local time in table"
+      equal assignment_ts.data('html-tooltip-title'), "Local: Jan 1 at 10:00am<br>Course: Jan 1 at 12:00pm", 'assignment - correct local and course times given'
+
+      event_ts = $('.events_2012_01_01 .related-appointment_group_1 .dates > span:nth-child(1)')
+      equal event_ts.text(), " 8am", "event - local time in table"
+      equal event_ts.data('html-tooltip-title'), "Local: Jan 1 at  8:00am<br>Course: Jan 1 at 10:00am", 'event - correct local and course times given'
+
   test 'render (user public course)', ->
     @view.can_read = true # public course -- can read
     @view.is_valid_user = true # user - enrolled (can read)