Skip to content

Commit bd24ff0

Browse files
author
Stanley Stuart
committed
update plugins to use a styleguide table
Test plan: - make sure the plugins index page (/plugins) looks alright. - make sure that all the links work ilke they did before. - make sure that links in the "website" column go to the rgiht place like they did before. - make sure the plugins page is still accessible. fixes CNVS-6870 Change-Id: If5fef9193387cda033e9e94cb825f8144614d6d9 Reviewed-on: https://gerrit.instructure.com/22308 Tested-by: Jenkins <jenkins@instructure.com> Reviewed-by: Derek DeVries <ddevries@instructure.com> QA-Review: Myller de Araujo <myller@instructure.com> Product-Review: Stanley Stuart <stanley@instructure.com>
1 parent 123eb0b commit bd24ff0

2 files changed

Lines changed: 6 additions & 60 deletions

File tree

app/stylesheets/plugins.scss

Lines changed: 0 additions & 58 deletions
This file was deleted.

app/views/plugins/index.html.erb

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
</h2>
1515

1616
<% if @plugins.any? %>
17-
<table class="list plugins">
17+
<table class="table table-striped">
1818
<tr>
1919
<th><%= t :name, "Name" %></th>
2020
<th><%= t :description, "Description" %></th>
@@ -35,7 +35,11 @@
3535
</td>
3636
<td class='description'><%= content_tag('span', h(plugin.description), :class => 'description') unless plugin.description.blank? %></td>
3737
<td class='tag'><%= h plugin.tag %></td>
38-
<td class='website'><%= content_tag('span', link_to(image_tag('link.png'), plugin.website), :class => 'url') unless plugin.website.blank? %></td>
38+
<td class='website'>
39+
<% if plugin.website.present? %>
40+
<a href="<%= plugin.website %>" class="icon-link"></a>
41+
<% end %>
42+
</td>
3943
<td class="author"><%= plugin.author_website.blank? ? h(plugin.author) : link_to(h(plugin.author), plugin.author_website) %></td>
4044
<td class="version"><%= h plugin.version %></td>
4145
<td class="configure"><%= link_to("", plugin_path(plugin.id), :class => "btn btn-mini icon-settings") if plugin.has_settings_partial? %></td>

0 commit comments

Comments
 (0)