Skip to content

Commit c35b325

Browse files
committed
Make edit profile links table more accessible
closes CNVS-30475 Test Plan: - Make sure profiles are enabled - Go to /profile - Switch to the edit view - Using a SR go into the links section - If there is no text in the "Title" column then when navigating through the table the columns in that row should read "Link Title" as the row header - If there is text in the "Title" column then the contents of that column should read as the row header on the columns in that row. For example, a row with "Google" and "http://google.com" should read "Google" as the row header when on the URL. Change-Id: I145f637e8c0c314a71cff3018e460d6a2bef85b4 Reviewed-on: https://gerrit.instructure.com/86943 Reviewed-by: Matthew Sessions <msessions@instructure.com> QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com> Tested-by: Jenkins Product-Review: Aaron Cannon <acannon@instructure.com>
1 parent fb9a4d3 commit c35b325

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
<tr>
2-
<td><input aria-label="{{t "Link title" }}" type="text" class="ic-Input" maxlength="255" name="link_titles[]" value="{{title}}"></td>
3-
<td>→</td>
2+
{{#if title.length}}
3+
<th scope="row">
4+
<input aria-label="{{title}}" type="text" class="ic-Input" maxlength="255" name="link_titles[]" value="{{title}}">
5+
</th>
6+
{{else}}
7+
<th scope="row"><input aria-label="{{t "Link Title" }}" type="text" class="ic-Input" maxlength="255" name="link_titles[]" value="{{title}}"></th>
8+
{{/if}}
9+
<td aria-hidden="true">→</td>
410
<td><input aria-label="{{t "Link Url" }}" type="text" class="ic-Input" name="link_urls[]" value="{{url}}"></td>
511
<td><a href="#" class="remove_link_row" data-event="removeLinkRow"><span class="screenreader-only">{{t "Remove" }}</span><i class="icon-end"></i></a></td>
612
</tr>

0 commit comments

Comments
 (0)