Skip to content

Commit c8690ae

Browse files
author
Dan Minkevitch
committed
Enqueue file thumbnail UI updates
Fixes CNVS-22819 Test Plan: * Create a course * Upload 100+ files into the root files directory * Navigate to Files in the course and watch the scroll bar as files load in * The page should still be responsive while the files are being loaded in, even with 100+ files there Change-Id: I8b3f9cb1b5622cf38820f8b0916806fd1f5b153b Reviewed-on: https://gerrit.instructure.com/64789 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> QA-Review: Ryan Allen <rallen@instructure.com> Product-Review: Dan Minkevitch <dan@instructure.com>
1 parent 49688f8 commit c8690ae

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

app/coffeescripts/react_files/components/FilesystemObjectThumbnail.coffee

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ define [
4747

4848
@props.model?.fetch
4949
success: (model, response, options) =>
50-
@setState(thumbnail_url: response.thumbnail_url) if response?.thumbnail_url
50+
setTimeout =>
51+
@setState(thumbnail_url: response.thumbnail_url) if response?.thumbnail_url
52+
, 0
5153
error: () ->
5254
clearTimeout(timeout)

spec/coffeescripts/react_files/components/FilesystemObjectThumbnailSpec.coffee

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,5 +89,6 @@ define [
8989
React.unmountComponentAtNode(@thumbnail.getDOMNode().parentNode)
9090

9191
test "fetches thumbnail_url and puts it into state", ->
92-
equal @thumbnail.state.thumbnail_url, "sweet_thumbnail_url", "fetches and set thumbnail url into state"
92+
@clock.tick(1000)
93+
ok @thumbnail.state.thumbnail_url is "sweet_thumbnail_url", "fetches and set thumbnail url into state"
9394

0 commit comments

Comments
 (0)