Skip to content

Commit cc349da

Browse files
author
Michael Brewer-Davis
committed
provide accessible label for LMGB heading
closes: OUT-60 Test plan: 1. In supported screenreaders, visit the learning mastery gradebook for an individual student. The heading of each outcome group should be treated like a single UI element. Change-Id: I28051255071d5b0631757d9fe49277169f4721c5 Reviewed-on: https://gerrit.instructure.com/93428 Tested-by: Jenkins Reviewed-by: Matt Berns <mberns@instructure.com> QA-Review: Cemal Aktas <caktas@instructure.com> Product-Review: Nathan Rogowski <nathan@instructure.com>
1 parent e06c6f5 commit cc349da

2 files changed

Lines changed: 11 additions & 4 deletions

File tree

app/stylesheets/bundles/grade_summary.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -383,6 +383,10 @@ $outcome-border: 1px solid #BCC2CA;
383383
&:hover {
384384
background-color: #f7f7f7;
385385
}
386+
&:focus {
387+
outline-width: 4px;
388+
outline-offset: -4px;
389+
}
386390
.outcome-icon i {
387391
line-height: 40px;
388392
}

app/views/jst/grade_summary/group.handlebars

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
1-
<div class="group-description" role='button' tabindex='0' aria-controls="group_detail-{{id}}" aria-expanded='false'>
2-
<div class="outcome-icon" aria-label="{{#t}}expand/collapse {{title}} Outcome Group{{/t}}">
1+
<div id="group_header-{{id}}" class="group-description" role='button' tabindex='0' aria-controls="group_detail-{{id}}" aria-expanded='false'>
2+
<label class="screenreader-only" for="group_header-{{id}}">
3+
{{#t}}Expand/collapse {{title}} Outcome Group, student meets mastery of {{mastery_count}} of {{count}} outcomes{{/t}}
4+
</label>
5+
<div class="outcome-icon">
36
<i class="icon-mini-arrow-down collapsed-arrow"></i>
47
<i class="icon-mini-arrow-up expanded-arrow"></i>
58
</div>
6-
<h3 class="group-title"><span role='button' tabindex='0'>{{title}}</span></h3>
7-
<div class="group-status">
9+
<h3 class="group-title" aria-hidden="true">{{title}}</h3>
10+
<div class="group-status" aria-hidden="true">
811
<ul class="pill">
912
<li
1013
{{#if mastery_count}}

0 commit comments

Comments
 (0)