Commit d5e07a7
Brad Horrocks
toggleClass expects a boolean, not a truthy value for 2nd param
Previously we were passing in undefined, which was fine until you toggled
true, then wanted to go back.
see: http://api.jquery.com/toggleclass/#toggleClass-className-switch
fixes CNVS-5365
test plan:
- have a user with a submitted assignment that hasnt been graded
- in GradeBook, open the message students who...
- select "scored less than"
- select "Haven't submitted yet"
- select "Haven't been graded yet"
- without fix, null will be displayed by the user
- with the fix, everything will look normal
Change-Id: Ic05b8c2eec513ef26f8f3cdf26d8b328c7a850e1
Reviewed-on: https://gerrit.instructure.com/37206
Reviewed-by: Cameron Matheson <cameron@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>1 parent 9f492ad commit d5e07a7
1 file changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
131 | 131 | | |
132 | 132 | | |
133 | 133 | | |
134 | | - | |
| 134 | + | |
| 135 | + | |
135 | 136 | | |
136 | 137 | | |
137 | 138 | | |
| |||
0 commit comments