draft state: add assignment scores to the assignments index page

Test Plan:
  - Enable draft state on your account.
  - As a teacher, create a few assignments in the course. At least one
    should have points possible, and one should have no points possible.
  - As a student, submit / complete a few of the assignments in the
    course.
  - As a teacher, grade the assignments. Make sure one assignment is
    left ungraded.
  - As a student, loading the assignments index page
    (/courses/:course_id/assignments) should show you your scores.
  - Make sure the content is accessible with a screenreader!

also does some miscellaneous qunit spec fixes

fixes CNVS-7203

Change-Id: I69e8896fc96bed5ec2978370b4115f491ac66071
Reviewed-on: https://gerrit.instructure.com/23570
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Stanley Stuart <stanley@instructure.com>

Author: Stanley Stuart

app/coffeescripts/bundles/assignment_index.coffee

@@ -42,6 +42,7 @@ require [
     params:
       include: includes
       override_assignment_dates: !ENV.PERMISSIONS.manage
+    courseSubmissionsURL: ENV.URLS.course_student_submissions_url
 
   assignmentGroupsView = new AssignmentGroupListView
     collection: assignmentGroups
@@ -67,16 +68,18 @@ require [
       course: course
       assignmentGroups: assignmentGroups
 
-  @app = new IndexView
+  app = new IndexView
     assignmentGroupsView: assignmentGroupsView
     assignmentSettingsView: assignmentSettingsView
     createGroupView: createGroupView
     showByView: showByView
     collection: assignmentGroups
 
-  @app.render()
+  app.render()
 
   # kick it all off
   assignmentGroups.fetch(reset: true).then ->
     if ENV.PERMISSIONS.manage
       assignmentGroups.loadModuleNames()
+    else
+      assignmentGroups.getGrades()

app/coffeescripts/collections/AssignmentGroupCollection.coffee

@@ -1,14 +1,19 @@
 define [
-  'underscore'
   'Backbone'
   'compiled/models/AssignmentGroup'
-], (_, Backbone, AssignmentGroup) ->
+  'underscore'
+  'i18n!assignments'
+  'compiled/collections/PaginatedCollection'
+], (Backbone, AssignmentGroup, _, I18n, PaginatedCollection) ->
+
+  PER_PAGE_LIMIT = 50
 
   class AssignmentGroupCollection extends Backbone.Collection
 
     model: AssignmentGroup
 
     @optionProperty 'course'
+    @optionProperty 'courseSubmissionsURL'
 
     # TODO: this will also return the assignments discussion_topic if it is of
     # that type, which we don't need.
@@ -34,3 +39,32 @@ define [
         .value()
 
     comparator: 'position'
+
+    getGrades: ->
+      collection = new PaginatedCollection
+      collection.url = => "#{@courseSubmissionsURL}?per_page=#{PER_PAGE_LIMIT}"
+      collection.loadAll = true
+      collection.on 'fetched:last', =>
+        @loadGradesFromSubmissions(collection.toArray())
+      collection.fetch()
+
+    loadGradesFromSubmissions: (submissions) ->
+      submissionsHash = {}
+      for submission in submissions
+        submissionsHash[submission.get('assignment_id')] = submission
+
+      for assignment in @assignments()
+        submission = submissionsHash[assignment.get('id')]
+        if submission
+          if submission.get('grade')?
+            grade = parseFloat submission.get('grade')
+            # may be a letter grade like 'A-'
+            if !isNaN grade
+              submission.set 'grade', grade
+          else
+            submission.set 'notYetGraded', true
+          assignment.set 'submission', submission
+        else
+          # manually trigger a change so the UI can update appropriately.
+          assignment.set 'submission', null
+          assignment.trigger 'change:submission'

app/coffeescripts/views/assignments/AssignmentListItemView.coffee

@@ -9,7 +9,11 @@ define [
   'compiled/views/MoveDialogView'
   'compiled/fn/preventDefault'
   'jst/assignments/AssignmentListItem'
-], (I18n, Backbone, _, PublishIconView, DateDueColumnView, DateAvailableColumnView, CreateAssignmentView, MoveDialogView, preventDefault, template) ->
+  'jst/assignments/_assignmentListItemScore'
+  'compiled/util/round'
+  'jqueryui/tooltip'
+  'compiled/behaviors/tooltip'
+], (I18n, Backbone, _, PublishIconView, DateDueColumnView, DateAvailableColumnView, CreateAssignmentView, MoveDialogView, preventDefault, template, scoreTemplate, round) ->
 
   class AssignmentListItemView extends Backbone.View
     tagName: "li"
@@ -50,6 +54,7 @@ define [
         attrs = ["name", "points_possible", "due_at", "lock_at", "unlock_at", "modules"]
         observe = _.map(attrs, (attr) -> "change:#{attr}").join(" ")
         @model.on(observe, @render)
+      @model.on 'change:submission', @updateScore
 
     initializeChildViews: ->
       @publishIconView    = false
@@ -100,6 +105,8 @@ define [
         @moveAssignmentView.hide()
         @moveAssignmentView.setTrigger @$moveAssignmentButton
 
+      @updateScore() unless @canManage()
+
     toggleHidden: (model, hidden) =>
       @$el.toggleClass('hidden', hidden)
       @$el.toggleClass('search_show', !hidden)
@@ -119,10 +126,19 @@ define [
     toJSON: ->
       data = @model.toView()
       data.canManage = @canManage()
+      data = @_setJSONForGrade(data) unless data.canManage
+
       # can move items if there's more than one parent
       # collection OR more than one in the model's collection
       data.canMove = @model.collection.view?.parentCollection?.length > 1 or @model.collection.length > 1
 
+      if data.canManage
+        data.spanWidth      = 'span3'
+        data.alignTextClass = ''
+      else
+        data.spanWidth      = 'span4'
+        data.alignTextClass = 'align-right'
+
       if modules = @model.get('modules')
         moduleName = modules[0]
         has_modules = modules.length > 0
@@ -147,3 +163,24 @@ define [
 
     canManage: ->
       ENV.PERMISSIONS.manage
+
+    _setJSONForGrade: (json) ->
+      if submission = @model.get('submission')
+        submissionJSON = submission.toJSON()
+        grade = submission.get('grade')
+        if typeof grade is 'number' && !isNaN(grade)
+          submissionJSON.grade = round grade, round.DEFAULT
+        json.submission = submissionJSON
+      pointsPossible = json.pointsPossible
+
+      if typeof pointsPossible is 'number' && !isNaN(pointsPossible)
+        json.pointsPossible = round pointsPossible, round.DEFAULT
+        json.submission.pointsPossible = json.pointsPossible if json.submission?
+
+      json
+
+    updateScore: =>
+      json = @model.toView()
+      json = @_setJSONForGrade(json) unless @canManage()
+
+      @$('.js-score').html scoreTemplate(json)

app/coffeescripts/views/content_migrations/ProgressStatusView.coffee

@@ -8,7 +8,7 @@ define [
       @progress = @model.progressModel
 
     render: ->
-      if statusView = @model.collection.view.getStatusView(@model)
+      if statusView = @model.collection?.view?.getStatusView(@model)
         @$el.html(statusView)
       else
         super

app/controllers/assignments_controller.rb

@@ -46,6 +46,7 @@ def index
           :sort_url => reorder_course_assignment_groups_url,
           :assignment_sort_base_url => course_assignment_groups_url,
           :context_modules_url => api_v1_course_context_modules_path(@context),
+          :course_student_submissions_url => api_v1_course_student_submissions_url(@context)
         },
         :PERMISSIONS => permissions,
       })

app/views/jst/assignments/AssignmentListItem.handlebars

@@ -14,7 +14,7 @@
   </a>
   <div class="ig-details row-fluid">
     {{#if canManage}}
-      <div class="span3 ellipses modules">
+      <div class="{{spanWidth}} ellipses modules">
         {{#if has_modules}}
           {{#ifEqual module_count 1}}
             {{module_name}} {{#t "module"}}Module{{/t}}
@@ -35,12 +35,22 @@
       </div>
     {{/if}}
 
-    <div class="span3 ellipses" data-view="date-available"></div>
-    <div class="span3 ellipses" data-view="date-due"></div>
+    <div class="{{spanWidth}} ellipses" data-view="date-available"></div>
+    <div class="{{spanWidth}} ellipses" data-view="date-due"></div>
 
-    <div class="span3 ellipses">
-      {{#if pointsPossible}}{{#t "points_possible"}}{{pointsPossible}} pts{{/t}}{{/if}}
+    <div class="{{spanWidth}} ellipses js-score {{alignTextClass}}">
+      <span class="screenreader-only">
+        {{#if pointsPossible}}
+          {{#t "points_possible_screen_reader"}}{{pointsPossible}} Points Possible{{/t}}
+        {{else}}
+          {{#t "no_points_possible"}}No Points Possible{{/t}}
+        {{/if}}
+      </span>
+      <span class="non-screenreader" aria-hidden="true">
+        {{#if pointsPossible}}{{#t "points_possible"}}{{pointsPossible}} pts{{/t}}{{/if}}
+      </span>
     </div>
+
   </div>
 
   {{#if canManage}}

app/views/jst/assignments/_assignmentListItemScore.handlebars

@@ -0,0 +1,63 @@
+<span class="non-screenreader" aria-hidden=true>
+
+  {{#unless submission}}
+
+    <span data-tooltip="" title='{{#t "no_submission"}}No Submission{{/t}}'>
+      {{#t "no_submission_with_points_possible"}}
+        -/{{pointsPossible}} pts
+      {{/t}}
+    </span>
+
+  {{else}}
+    {{#with submission}}
+      {{#if notYetGraded}}
+
+        {{#t "not_yet_graded_with_points_possible"}}
+          <em>Not Yet Graded</em>/{{pointsPossible}} pts
+        {{/t}}
+
+      {{else}}
+
+        <strong>
+          {{#t "score_with_points_possible"}}
+            {{grade}}/{{pointsPossible}} pts
+          {{/t}}
+        </strong>
+
+      {{/if}}
+
+    {{/with}}
+
+  {{/unless}}
+
+</span>
+
+<span class="screenreader-only">
+
+  {{#unless submission}}
+
+    {{#t "no_submission_for_assignment_screenreader"}}
+      No submission for this assignment. {{pointsPossible}} points possible.
+    {{/t}}
+
+  {{else}}
+    {{#with submission}}
+      {{#if notYetGraded}}
+
+        {{#t "assignment_not_yet_graded_screenreader"}}
+          Assignment not yet graded. {{pointsPossible}} points possible.
+        {{/t}}
+
+      {{else}}
+
+        {{#t "score_with_points_possible_screenreader"}}
+          Score: {{grade}} out of {{pointsPossible}} points
+        {{/t}}
+
+      {{/if}}
+
+    {{/with}}
+
+  {{/unless}}
+
+</span>

spec/coffeescripts/collections/AssignmentGroupCollectionSpec.coffee

@@ -0,0 +1,65 @@
+define [
+  'compiled/models/AssignmentGroup'
+  'compiled/models/Assignment'
+  'compiled/collections/AssignmentGroupCollection'
+  'compiled/models/Course'
+], (AssignmentGroup, Assignment, AssignmentGroupCollection, Course) ->
+
+  COURSE_SUBMISSIONS_URL = "/courses/1/submissions"
+
+  module "AssignmentGroupCollection",
+    setup: ->
+      @server       = sinon.fakeServer.create()
+      @assignments  = (new Assignment({id: id}) for id in [1..4])
+      @group        = new AssignmentGroup assignments: @assignments
+      @collection   = new AssignmentGroupCollection [@group],
+        courseSubmissionsURL: COURSE_SUBMISSIONS_URL
+
+    teardown: ->
+      @server.restore()
+
+  test "::model is AssignmentGroup", ->
+    strictEqual AssignmentGroupCollection::model, AssignmentGroup
+
+  test "default params include assignments and not discussion topics", ->
+    {include} = AssignmentGroupCollection::defaults.params
+    deepEqual include, ["assignments"], "include only contains assignments"
+
+  test "optionProperties", ->
+    course     = new Course
+    collection = new AssignmentGroupCollection [],
+      course: course
+      courseSubmissionsURL: COURSE_SUBMISSIONS_URL
+
+    strictEqual collection.courseSubmissionsURL, COURSE_SUBMISSIONS_URL,
+      "assigns courseSubmissionsURL to this.courseSubmissionsURL"
+
+    strictEqual collection.course, course, "assigns course to this.course"
+
+  test "(#getGrades) loading grades from the server", ->
+    triggeredChangeForAssignmentWithoutSubmission = false
+    submissions = ({id: id, assignment_id: id, grade: id} for id in [1..3])
+    @server.respondWith "GET", "#{COURSE_SUBMISSIONS_URL}?per_page=50", [
+      200,
+      { "Content-Type": "application/json" },
+      JSON.stringify(submissions)
+    ]
+
+    lastAssignment = @assignments[3]
+    lastAssignment.on 'change:submission', ->
+      triggeredChangeForAssignmentWithoutSubmission = true
+
+    @collection.getGrades()
+    @server.respond()
+
+    for assignment in @assignments
+      continue if assignment.get("id") is 4
+      equal assignment.get("submission").get("grade"), assignment.get("id"),
+        "sets submission grade for assignments with a matching submission"
+
+    ok triggeredChangeForAssignmentWithoutSubmission,
+      """
+      triggers change for assignments without a matching submission grade
+      so the UI can update
+      """
+

spec/coffeescripts/views/MoveDialogSelectSpec.coffee

@@ -18,7 +18,6 @@ define [
   module 'MoveDialogSelect',
     setup: ->
       @set_coll_spy = sinon.spy MoveDialogSelect.prototype, 'setCollection'
-      @render_spy = sinon.spy MoveDialogSelect.prototype, 'render'
 
       @assignments = new Assignments((id: i, name: "Assignment #{i}") for i in [1..3])
       @view = new MoveDialogSelect
@@ -28,7 +27,6 @@ define [
 
     teardown: ->
       @set_coll_spy.restore()
-      @render_spy.restore()
 
   test '#initialize, if a collection is not passed the model\'s collection will be used for @collection', ->
     deepEqual @view.model.collection, @assignments
@@ -63,10 +61,11 @@ define [
     ok @set_coll_spy.returned(undefined)
 
   test '#setCollection changes the value of @collection', ->
+    spy = sinon.spy @view, 'renderOptions'
     other_assignments = new Assignments((id: i, name: "Assignment #{i}") for i in [5..9])
     @view.setCollection(other_assignments)
     deepEqual @view.collection, other_assignments
-    ok @render_spy.called
+    ok spy.called
 
   test '#toJSON returns an object that can be used for rendering the select', ->
     expected = @view.model.toView()