rails3: fix RequestContextGenerator middleware order

Make sure it comes before ActionDispatch's logging of the request start

fixes CNVS-13890

test plan: turn on 'log_context: true' in config/logging.yml, and make
sure that the `Started GET "/path"` lines have the correct request id of the
subsequent request, not the previous request.

Change-Id: Ie6a77993955296b9032e07f8536506b6816517b7
Reviewed-on: https://gerrit.instructure.com/37183
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>

Author: codekitchen

lib/request_context_generator.rb …/middleware/request_context_generator.rblib/request_context_generator.rb renamed to app/middleware/request_context_generator.rb lib/request_context_generator.rb renamed to app/middleware/request_context_generator.rb

@@ -76,7 +76,7 @@
 end
 
 params_parser = CANVAS_RAILS2 ? 'ActionController::ParamsParser' : 'ActionDispatch::ParamsParser'
-config.middleware.insert_before(params_parser, "RequestContextGenerator")
+config.middleware.insert_before(CANVAS_RAILS2 ? params_parser : 'ActionDispatch::RequestId', "RequestContextGenerator")
 config.middleware.insert_before(params_parser, 'StatsTiming')
 config.middleware.insert_before(params_parser, 'Canvas::RequestThrottle')
 config.middleware.insert_before(params_parser, 'PreventNonMultipartParse')