fix image/file upload section in eportfolios, fixes #3756

It looks like at some point we switched from an "upload" to an "attachment"
section type, which broke this

Change-Id: I49f1a45ad5b39acd00376504962b9841264d4bd0
Reviewed-on: https://gerrit.instructure.com/2227
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Whitmer <brian@instructure.com>

Author: zwily

app/models/eportfolio_entry.rb

@@ -74,7 +74,7 @@ def full_slug
   def attachments
     res = []
     content_sections.each do |section|
-      res << (self.eportfolio.user.all_attachments.find_by_uuid(section["attachment_id"]) rescue nil) if section["section_type"] == "upload"
+      res << (self.eportfolio.user.all_attachments.find_by_id(section["attachment_id"]) rescue nil) if section["section_type"] == "attachment"
     end
     res.compact
   end

app/stylesheets/instructure_eportfolio.sass

@@ -141,12 +141,15 @@ ul.submission_list.instTree li.submission.leaf
 
 #page_content 
   .section 
-    .upload 
+    .attachment 
       :font-size 1.1em
 
       .filename 
         :font-weight bold
         :text-decoration underline
+      
+      img
+        :max-width 100%
 
     .file_list 
       :text-align left

app/views/eportfolios/_page_section.html.erb

@@ -7,7 +7,7 @@
       HTML/Embedded Content
     <% elsif page_section["section_type"] == "submission" %>
       Course Submission
-    <% elsif page_section["section_type"] == "upload" %>
+    <% elsif page_section["section_type"] == "attachment" %>
       Image/File Upload
     <% end %>
   </div>
@@ -18,9 +18,9 @@
     <% if page_section %>
       <% if !page_section["section_type"] || page_section["section_type"] == "rich_text" || page_section["section_type"] == "html" %>
         <%= raw(page_section["content"] || "Nothing Entered Yet") %>
-      <% elsif page_section["section_type"] == "upload" %>
-        <div style="text-align: center;" class="upload">
-          <% attachment = @attachments.find{|a| a.uuid == page_section["attachment_id"]} %>
+      <% elsif page_section["section_type"] == "attachment" %>
+        <div style="text-align: center;" class="attachment">
+          <% attachment = @portfolio.user.attachments.find(page_section["attachment_id"]) %>
           <% if attachment && attachment.content_type.match(/\Aimage/) %>
             <a href="<%= eportfolio_entry_view_file_path(@portfolio, @page, attachment.uuid) %>" class="no-hover"><%= image_tag eportfolio_entry_view_file_path(@portfolio, @page, attachment.uuid) %></a>
           <% elsif attachment %>

app/views/eportfolios/_page_section_static.html.erb

@@ -4,8 +4,8 @@
   <div class="section_content">
       <% if !page_section["section_type"] || page_section["section_type"] == "rich_text" || page_section["section_type"] == "html" %>
         <%= page_section["content"] || "Nothing Entered Yet" %>
-      <% elsif page_section["section_type"] == "upload" %>
-        <div style="text-align: center;" class="upload">
+      <% elsif page_section["section_type"] == "attachment" %>
+        <div style="text-align: center;" class="attachment">
           <% attachment = @static_attachments.find{|a| a.uuid == page_section["attachment_id"]} %>
           <% if attachment && attachment.content_type.match(/\Aimage/) %>
             <a href="<%= attachment.filename %>"><img src="<%= attachment.filename %>" alt="<%= attachment.filename %>"/></a>

public/javascripts/eportfolio.js

@@ -304,7 +304,7 @@
             var id = data.id;
             var uuid = $("#file_uuid_" + id).text();
             var name = data.name;
-            $section.find(".attachment_id").text(uuid);
+            $section.find(".attachment_id").text(id);
             var url = $(".eportfolio_download_url").attr('href');
             url = $.replaceTags(url, 'uuid', uuid);
             if($file.hasClass('image')) {
@@ -334,7 +334,7 @@
       success: function(data) {
         var $section = $(this).data('section');
         var attachment = data.attachment;
-        $section.find(".attachment_id").text(attachment.uuid);
+        $section.find(".attachment_id").text(attachment.id);
         var url = $(".eportfolio_download_url").attr('href');
         url = $.replaceTags(url, 'uuid', attachment.uuid);
         if(attachment.content_type.indexOf("image") != -1) {

public/stylesheets/static/eportfolio_static.css

@@ -211,9 +211,9 @@ img {
 
 #page_content .section .upload {
   font-size: 1.1em; }
-  #page_content .section .upload .filename {
-    font-weight: bold;
-    text-decoration: underline; }
+#page_content .section .upload .filename {
+  font-weight: bold;
+  text-decoration: underline; }
 #page_content .section .file_list {
   text-align: left; }
 #page_content .section .file_list .instTree .leaf.active {