support funky characters in username/passwords for http url parsing

Change-Id: Ia0346a08a1e6bfdafdabe14b3b3be813965ef07f
Reviewed-on: https://gerrit.instructure.com/5482
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>

Author: jtolio

lib/ssl_common.rb

@@ -36,7 +36,7 @@ def raw_post(url, payload, headers = {}, form_data = nil)
       url = URI.parse(url)
       http = self.get_http_conn(url.host, url.port, url.scheme.downcase == 'https')
       req = Net::HTTP::Post.new(url.request_uri, headers)
-      req.basic_auth url.user, url.password if url.user
+      req.basic_auth URI.unescape(url.user || ""), URI.unescape(url.password || "") if url.user
       req.form_data = form_data if form_data
       http.start {|http| http.request(req, payload) }
     end

spec/lib/ssl_common_spec.rb

@@ -33,6 +33,20 @@
         "somedata"]
   end
 
+  it "should work with http basic auth, username and password, with encoded characters" do
+    server, server_thread, post_lines = start_test_http_server
+    SSLCommon.post_data("http://theusername%40theuseremail.tld:thepassword@localhost:#{server.addr[1]}/endpoint",
+        "somedata", "application/x-jt-is-so-cool")
+    server_thread.join
+    post_lines.should == [
+        "POST /endpoint HTTP/1.1",
+        "Accept: */*",
+        "Content-Type: application/x-jt-is-so-cool",
+        "Authorization: Basic #{Base64.encode64("theusername@theuseremail.tld:thepassword").strip}",
+        "",
+        "somedata"]
+  end
+
   it "should work with http basic auth, just username" do
     server, server_thread, post_lines = start_test_http_server
     SSLCommon.post_data("http://theusername@localhost:#{server.addr[1]}/endpoint",