Skip to content

Commit f6b74d7

Browse files
committed
show quiz action icons on touch devices
The Edit, Delete, and Move action icons for a question in the quiz edit form were not visible on touch-enabled devices as the CSS would only show them based on the :hover state of their container which isn't always eligible when using touch devices. The issue was reported by some users using Chrome and Firefox on a regular non-touch device, however I was unable to reproduce the issue on any of the following platforms/browsers: Windows 7 (x64) Chrome: 17.0.963.83, 18.0.1025.168, 19.0.1084.56, 20.0.1132.57, 21.0.1180.89, 22.0.1229.94, 23.0.1271.97, 24.0.1312.57 Firefox: 3.6.28, 4.0.1, 5.0.1, 17.0.1, 18.0.2 Windows 8 (x64) Chrome: 24.0.1312.57 Firefox: 18.0.2 Linux (Arch x64) Chromeium: 24.0.1312.69 Google Chrome: 23.0.1271.64 Firefox: 18.0.2 However, the issue was reproducible on: 1. iPhone 4S (iOS 6) 2. iPad 4 (iOS 6.1) -- NOTE -- The committed change will apply to "hybrid" browsers which may report both touch and no-touch capabilities by FALLING BACK to the touch mode (the icons will be visible regardless of the hover state). So, they will be accessible but not optimal. -- Test plan * create a quiz with one or two questions * using an iPad or an iPhone, edit the quiz * look at the question containers, the edit and delete buttons to the right should be shown, and the move icon to the left as well * using a desktop (or any no-touch device) browser, edit the quiz and the icons should be hidden unless you hover over the question closes CNVS-2022 see also CNVS-6966 see also gerrit-8825 (https://gerrit.instructure.com/#/c/8825/) Change-Id: If8c8221523ce11fc469e19fe58e9337b8bcd635c Reviewed-on: https://gerrit.instructure.com/17679 Tested-by: Jenkins <jenkins@instructure.com> Reviewed-by: Simon Williams <simon@instructure.com> QA-Review: Myller de Araujo <myller@instructure.com>
1 parent 3212284 commit f6b74d7

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

app/stylesheets/quizzes.sass

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,9 @@ div#content
440440
&.marked,&.marked:hover
441441
.flag_question
442442
:background-position -48px -17px
443-
.no-touch &.hover
443+
444+
.no-touch &.hover,
445+
.touch &
444446
.move
445447
:background-color #fff
446448
.move_icon

0 commit comments

Comments
 (0)