Refactor Group Limit specs to remove redundancy

Test Plan:
  - Run Specs

Change-Id: I099e39d80463c9a64a110dcdab9e5beccf28e093
Reviewed-on: https://gerrit.instructure.com/54899
Tested-by: Jenkins
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>

Author: Steven Shepherd

spec/selenium/groups_teacher_spec.rb

@@ -144,25 +144,15 @@
       expect(f('.group-category-summary')).to include_text("Groups are limited to 2 members.")
 
       # Creates a group and checks to see if group set's limit is inherited by its groups
-      f('.btn.add-group').click
-      wait_for_ajaximations
-      f('#group_name').send_keys("Test Group")
-      f('#groupEditSaveButton').click
-      wait_for_ajaximations
+      manually_create_group
       expect(f('.group-summary')).to include_text("0 / 2 students")
     end
 
     it "should allow a teacher to set up a group with member limits", priority: "1", test_id: 94161 do
       group_test_setup(3,1,0)
       get "/courses/#{@course.id}/groups"
 
-      f('.btn.add-group').click
-      wait_for_ajaximations
-      f('#group_name').send_keys("Test Group")
-      f('#group_max_membership').send_keys("2")
-      wait_for_ajaximations
-      f('#groupEditSaveButton').click
-      wait_for_ajaximations
+      manually_create_group(has_max_membership:true, member_count:2)
       expect(f('.group-summary')).to include_text("0 / 2 students")
     end
   end

spec/selenium/helpers/groups_common.rb

@@ -93,6 +93,25 @@ def create_student_group_as_a_teacher(group_name = "Windfury", enroll_student_co
   group
 end
 
+def manually_create_group(params={})
+  default_params = {
+    group_name:'Test Group',
+    has_max_membership:false,
+    member_count:0,
+  }
+  params = default_params.merge(params)
+
+  f('.btn.add-group').click
+  wait_for_ajaximations
+  f('#group_name').send_keys(params[:group_name])
+  if params[:has_max_membership]
+    f('#group_max_membership').send_keys(params[:member_count])
+    wait_for_ajaximations
+  end
+  f('#groupEditSaveButton').click
+  wait_for_ajaximations
+end
+
 def delete_group
   f(".icon-settings").click
   wait_for_animations