Skip to content

Commit fb80d29

Browse files
ccutrerccutrer
committed
i18n role_overrides
Change-Id: Iec9e848ea8eb443ec14ab768835153139e1b006b Reviewed-on: https://gerrit.instructure.com/4308 Tested-by: Hudson <hudson@instructure.com> Reviewed-by: Brian Palmer <brianp@instructure.com>
1 parent d738437 commit fb80d29

4 files changed

Lines changed: 67 additions & 97 deletions

File tree

‎app/controllers/role_overrides_controller.rb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def create
8181
end
8282
end
8383
end
84-
flash[:notice] = 'Changes Saved Successfully.'
84+
flash[:notice] = t 'notices.saved', "Changes Saved Successfully."
8585
redirect_to named_context_url(@context, :context_role_overrides_url, :account_roles => params[:account_roles])
8686
end
8787
end

‎app/models/role_override.rb‎

Lines changed: 37 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def default_values
2929
end
3030

3131
def self.account_membership_types(account)
32-
res = [{:name => "AccountAdmin", :label => "Account Admin"}]
32+
res = [{:name => "AccountAdmin", :label => t('roles.account_admin', "Account Admin")}]
3333
(account.account_membership_types - ['AccountAdmin']).each do |t|
3434
res << {:name => t, :label => t}
3535
end
@@ -38,11 +38,11 @@ def self.account_membership_types(account)
3838

3939
ENROLLMENT_TYPES =
4040
[
41-
{:name => 'StudentEnrollment', :label => 'Student'},
42-
{:name => 'TaEnrollment', :label => 'TA'},
43-
{:name => 'TeacherEnrollment', :label => 'Teacher'},
44-
{:name => 'DesignerEnrollment', :label => 'Course Designer'},
45-
{:name => 'ObserverEnrollment', :label => 'Observer'}
41+
{:name => 'StudentEnrollment', :label => lambda { t('roles.student', 'Student') } },
42+
{:name => 'TaEnrollment', :label => lambda { t('roles.ta', 'TA') } },
43+
{:name => 'TeacherEnrollment', :label => lambda { t('roles.teacher', 'Teacher') } },
44+
{:name => 'DesignerEnrollment', :label => lambda { t('roles.designer', 'Course Designer') } },
45+
{:name => 'ObserverEnrollment', :label => lambda { t('roles.observer', 'Observer') } }
4646
].freeze
4747
def self.enrollment_types
4848
ENROLLMENT_TYPES
@@ -65,7 +65,7 @@ def self.known_role_types
6565
PERMISSIONS =
6666
{
6767
:manage_wiki => {
68-
:label => "Manage Wiki (add / edit / delete pages)",
68+
:label => lambda { t('permissions.manage_wiki', "Manage Wiki (add / edit / delete pages)") },
6969
:available_to => [
7070
'TaEnrollment',
7171
'TeacherEnrollment',
@@ -83,7 +83,7 @@ def self.known_role_types
8383
]
8484
},
8585
:post_to_forum => {
86-
:label => "Post to discussions",
86+
:label => lambda { t('permissions.post_to_forum', "Post to discussions") },
8787
:available_to => [
8888
'StudentEnrollment',
8989
'TaEnrollment',
@@ -102,7 +102,7 @@ def self.known_role_types
102102
]
103103
},
104104
:moderate_forum => {
105-
:label => "Moderate discussions ( delete / edit other's posts, lock topics)",
105+
:label => lambda { t('permissions.moderate_form', "Moderate discussions ( delete / edit other's posts, lock topics)") },
106106
:available_to => [
107107
'StudentEnrollment',
108108
'TaEnrollment',
@@ -121,7 +121,7 @@ def self.known_role_types
121121
]
122122
},
123123
:send_messages => {
124-
:label => "Send messages to course members",
124+
:label => lambda { t('permissions.send_messages', "Send messages to course members") },
125125
:available_to => [
126126
'StudentEnrollment',
127127
'TaEnrollment',
@@ -141,7 +141,7 @@ def self.known_role_types
141141
]
142142
},
143143
:manage_outcomes => {
144-
:label => "Manage Learning Outcomes",
144+
:label => lambda { t('permissions.manage_outcomes', "Manage Learning Outcomes") },
145145
:available_to => [
146146
'StudentEnrollment',
147147
'TaEnrollment',
@@ -160,7 +160,7 @@ def self.known_role_types
160160
]
161161
},
162162
:create_conferences => {
163-
:label => "Create web conferences",
163+
:label => lambda { t('permissions.create_conferences', "Create web conferences") },
164164
:available_to => [
165165
'StudentEnrollment',
166166
'TaEnrollment',
@@ -180,7 +180,7 @@ def self.known_role_types
180180
]
181181
},
182182
:create_collaborations => {
183-
:label => "Create student collaborations",
183+
:label => lambda { t('permissions.create_collaborations', "Create student collaborations") },
184184
:available_to => [
185185
'StudentEnrollment',
186186
'TaEnrollment',
@@ -200,7 +200,7 @@ def self.known_role_types
200200
]
201201
},
202202
:read_roster => {
203-
:label => "See the list of users",
203+
:label => lambda { t('permissions.read_roster', "See the list of users") },
204204
:available_to => [
205205
'StudentEnrollment',
206206
'TaEnrollment',
@@ -220,7 +220,7 @@ def self.known_role_types
220220
]
221221
},
222222
:view_all_grades => {
223-
:label => "View all grades",
223+
:label => lambda { t('permissions.view_all_grades', "View all grades") },
224224
:available_to => [
225225
'TaEnrollment',
226226
'DesignerEnrollment',
@@ -236,7 +236,7 @@ def self.known_role_types
236236
]
237237
},
238238
:manage_grades => {
239-
:label => "Edit grades (includes assessing rubrics)",
239+
:label => lambda { t('permissions.manage_grades', "Edit grades (includes assessing rubrics)") },
240240
:available_to => [
241241
'TaEnrollment',
242242
'TeacherEnrollment',
@@ -250,7 +250,7 @@ def self.known_role_types
250250
]
251251
},
252252
:comment_on_others_submissions => {
253-
:label => "View all students' submissions and make comments on them",
253+
:label => lambda { t('permissions.comment_on_others_submissions', "View all students' submissions and make comments on them") },
254254
:available_to => [
255255
'StudentEnrollment',
256256
'TaEnrollment',
@@ -268,7 +268,7 @@ def self.known_role_types
268268
]
269269
},
270270
:manage_students => {
271-
:label => "Add/Remove students for the course",
271+
:label => lambda { t('permissions.manage_students', "Add/Remove students for the course") },
272272
:available_to => [
273273
'TaEnrollment',
274274
'DesignerEnrollment',
@@ -285,7 +285,7 @@ def self.known_role_types
285285
]
286286
},
287287
:manage_admin_users => {
288-
:label => "Add/Remove other teachers, Course Designers or TAs to the course",
288+
:label => lambda { t('permissions.manage_admin_users', "Add/Remove other teachers, Course Designers or TAs to the course") },
289289
:available_to => [
290290
'TaEnrollment',
291291
'DesignerEnrollment',
@@ -299,7 +299,7 @@ def self.known_role_types
299299
]
300300
},
301301
:manage_role_overrides => {
302-
:label => "Manage default role permissions (define these permissions for course role types)",
302+
:label => lambda { t('permissions.manage_role_overrides', "Manage default role permissions (define these permissions for course role types)") },
303303
:available_to => [
304304
'TaEnrollment',
305305
'DesignerEnrollment',
@@ -313,7 +313,7 @@ def self.known_role_types
313313
]
314314
},
315315
:manage_account_memberships => {
316-
:label => "Add/Remove other admins for the account",
316+
:label => lambda { t('permissions.manage_account_memberships', "Add/Remove other admins for the account") },
317317
:available_to => [
318318
'AccountAdmin',
319319
'AccountMembership'
@@ -324,7 +324,7 @@ def self.known_role_types
324324
:account_only => true
325325
},
326326
:manage_account_settings => {
327-
:label => "Manage account-level settings",
327+
:label => lambda { t('permissions.manage_account_settings', "Manage account-level settings") },
328328
:available_to => [
329329
'AccountAdmin',
330330
'AccountMembership'
@@ -335,7 +335,7 @@ def self.known_role_types
335335
:account_only => true
336336
},
337337
:manage_groups => {
338-
:label => "Manage (create / edit / delete) groups",
338+
:label => lambda { t('permissions.manage_groups', "Manage (create / edit / delete) groups") },
339339
:available_to => [
340340
'TaEnrollment',
341341
'DesignerEnrollment',
@@ -351,7 +351,7 @@ def self.known_role_types
351351
]
352352
},
353353
:view_group_pages => {
354-
:label => "View the group pages of all student groups",
354+
:label => lambda { t('permissions.view_group_pages', "View the group pages of all student groups") },
355355
:available_to => [
356356
'StudentEnrollment',
357357
'TaEnrollment',
@@ -369,7 +369,7 @@ def self.known_role_types
369369
]
370370
},
371371
:manage_files => {
372-
:label => "Manage (add / edit / delete) course files",
372+
:label => lambda { t('permissions.manage_files', "Manage (add / edit / delete) course files") },
373373
:available_to => [
374374
'TaEnrollment',
375375
'DesignerEnrollment',
@@ -387,7 +387,7 @@ def self.known_role_types
387387
]
388388
},
389389
:manage_assignments => {
390-
:label => "Manage (add / edit / delete) assignments and quizes",
390+
:label => lambda { t('permissions.manage_assignments', "Manage (add / edit / delete) assignments and quizzes") },
391391
:available_to => [
392392
'TaEnrollment',
393393
'DesignerEnrollment',
@@ -405,7 +405,7 @@ def self.known_role_types
405405
]
406406
},
407407
:manage_calendar => {
408-
:label => "Add, edit and delete events on the course calendar",
408+
:label => lambda { t('permissions.manage_calendar', "Add, edit and delete events on the course calendar") },
409409
:available_to => [
410410
'StudentEnrollment',
411411
'TaEnrollment',
@@ -424,7 +424,7 @@ def self.known_role_types
424424
]
425425
},
426426
:read_reports => {
427-
:label => "View usage reports for the course",
427+
:label => lambda { t('permissions.read_reports', "View usage reports for the course") },
428428
:available_to => [
429429
'StudentEnrollment',
430430
'TaEnrollment',
@@ -441,7 +441,7 @@ def self.known_role_types
441441
]
442442
},
443443
:manage_courses => {
444-
:label => "Add/Remove Courses for the account",
444+
:label => lambda { t('permissions.manage_courses', "Add/Remove Courses for the account") },
445445
:available_to => [
446446
'AccountAdmin',
447447
'AccountMembership'
@@ -452,7 +452,7 @@ def self.known_role_types
452452
]
453453
},
454454
:manage_user_logins => {
455-
:label => "Modify Login details for users",
455+
:label => lambda { t('permissions.manage_user_logins', "Modify Login details for users") },
456456
:available_to => [
457457
'AccountAdmin',
458458
'AccountMembership'
@@ -463,32 +463,32 @@ def self.known_role_types
463463
]
464464
},
465465
:manage_alerts => {
466-
:label => "Manage account user alerts",
466+
:label => lambda { t('permissions.manage_alerts', "Manage account user alerts") },
467467
:account_only => true,
468468
:true_for => %w(AccountAdmin),
469469
:available_to => %w(AccountAdmin AccountMembership),
470470
},
471471

472472
:site_admin => {
473-
:label => "Use the Site Admin section and admin all other accounts",
473+
:label => lambda { t('permissions.site_admin', "Use the Site Admin section and admin all other accounts") },
474474
:account_only => :site_admin,
475475
:true_for => %w(AccountAdmin),
476476
:available_to => %w(AccountAdmin AccountMembership),
477477
},
478478
:become_user => {
479-
:label => "Become other users",
479+
:label => lambda { t('permissions.become_user', "Become other users") },
480480
:account_only => :site_admin,
481481
:true_for => %w(AccountAdmin),
482482
:available_to => %w(AccountAdmin AccountMembership),
483483
},
484484
:manage_site_settings => {
485-
:label => "Manage site-wide and plugin settings",
485+
:label => lambda { t('permissions.manage_site_settings', "Manage site-wide and plugin settings") },
486486
:account_only => :site_admin,
487487
:true_for => %w(AccountAdmin),
488488
:available_to => %w(AccountAdmin AccountMembership),
489489
},
490490
:manage_sis => {
491-
:label => "Import and manage SIS data",
491+
:label => lambda { t('permissions.manage_sis', "Import and manage SIS data") },
492492
:account_only => true,
493493
:true_for => %w(AccountAdmin),
494494
:available_to => %w(AccountAdmin AccountMembership),
@@ -520,9 +520,9 @@ def self.readonly_for(context, permission, enrollment_type)
520520
def self.title_for(context, permission, enrollment_type)
521521
generated_permission = self.permission_for(context, permission, enrollment_type)
522522
if generated_permission[:readonly]
523-
"you do not have permission to change this."
523+
t 'tooltips.readonly', "you do not have permission to change this."
524524
else
525-
"Click to toggle this permission ON or OFF"
525+
t 'tooltips.toogle', "Click to toggle this permission ON or OFF"
526526
end
527527
end
528528

‎app/views/role_overrides/_permission.html.erb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<% key, permission = permission -%>
22
<tr class="<%= cycle("even", "odd") %>">
3-
<th scope="row"><%= permission[:label] %></th>
3+
<th scope="row"><%= permission[:label].call() %></th>
44
<% @role_types.each do |enrollment_type| %>
55
<td>
66
<%= image_tag "locked_small.png", :class => "lock #{

0 commit comments

Comments
 (0)