Added announcement spec_ids and removed 3 duplicate specs

Change-Id: I64f82f8e2275d09de8d2cd2f50e6aee635447467
Reviewed-on: https://gerrit.instructure.com/58038
Tested-by: Jenkins
Reviewed-by: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Derek Hansen <dhansen@instructure.com>

Author: kinezu

…nium/announcements_public_course_spec.rb …ents/announcements_public_course_spec.rbspec/selenium/announcements_public_course_spec.rb renamed to spec/selenium/announcements/announcements_public_course_spec.rb spec/selenium/announcements_public_course_spec.rb renamed to spec/selenium/announcements/announcements_public_course_spec.rb

@@ -1,5 +1,5 @@
-require File.expand_path(File.dirname(__FILE__) + '/common')
-require File.expand_path(File.dirname(__FILE__) + '/helpers/announcements_common')
+require File.expand_path(File.dirname(__FILE__) + '/../common')
+require File.expand_path(File.dirname(__FILE__) + '/../helpers/announcements_common')
 
 describe "announcements public course" do
   include_examples "in-process server selenium tests"
@@ -18,18 +18,18 @@
       @announcement.discussion_entries.create!(:user => @student2, :parent_entry => s1e, :message => "Hello I'm student 2!")
     end
 
-    it "does not display replies on announcements to unauthenticated users" do
+    it "does not display replies on announcements to unauthenticated users", priority: "1", test_id: 220381 do
       get "/courses/#{@course.id}/discussion_topics/#{@announcement.id}"
       wait_for_ajaximations
       expect(f('#discussion_subentries span').text).to match(/must log in/i)
     end
 
-    it "does not display replies on announcements to users not enrolled in the course" do
+    it "does not display replies on announcements to users not enrolled in the course", priority: "1", test_id: 220382 do
       user_session(user)
 
       get "/courses/#{@course.id}/discussion_topics/#{@announcement.id}"
       wait_for_ajaximations
       expect(f('#discussion_subentries span').text).to match(/must log in/i)
     end
   end
-end
+end

…c/selenium/announcements_student_spec.rb …ouncements/announcements_student_spec.rbspec/selenium/announcements_student_spec.rb renamed to spec/selenium/announcements/announcements_student_spec.rb spec/selenium/announcements_student_spec.rb renamed to spec/selenium/announcements/announcements_student_spec.rb

@@ -1,10 +1,10 @@
-require File.expand_path(File.dirname(__FILE__) + '/common')
-require File.expand_path(File.dirname(__FILE__) + '/helpers/announcements_common')
+require File.expand_path(File.dirname(__FILE__) + '/../common')
+require File.expand_path(File.dirname(__FILE__) + '/../helpers/announcements_common')
 
 describe "announcements" do
   include_examples "in-process server selenium tests"
 
-  it "should validate replies are not visible until after users post" do
+  it "should validate replies are not visible until after users post", priority: "1", test_id: 150533 do
     password = 'asdfasdf'
     student_2_entry = 'reply from student 2'
     topic_title = 'new replies hidden until post topic'
@@ -46,12 +46,12 @@
       course_with_student_logged_in
     end
 
-    it "should not show an announcements section if there are no announcments" do
+    it "should not show an announcements section if there are no announcements", priority: "1", test_id: 150534 do
       get "/courses/#{@course.id}"
       expect(f(".announcements active")).to be_nil
     end
 
-    it "should not show JSON when loading more announcements via pageless" do
+    it "should not show JSON when loading more announcements via pageless", priority: "2", test_id: 220375 do
       50.times { @course.announcements.create!(:title => 'Hi there!', :message => 'Announcement time!') }
       get "/courses/#{@course.id}/announcements"
 
@@ -62,7 +62,7 @@
       expect(f(".discussionTopicIndexList")).not_to include_text('discussion_topic')
     end
 
-    it "should validate that a student can not see an announcement with a delayed posting date" do
+    it "should validate that a student can not see an announcement with a delayed posting date", priority: "1", test_id: 220376 do
       announcement_title = 'Hi there!'
       announcement = @course.announcements.create!(:title => announcement_title, :message => 'Announcement time!', :delayed_post_at => Time.now + 1.day)
       get "/courses/#{@course.id}/announcements"
@@ -74,7 +74,7 @@
       expect(f(".discussion-topic")).to include_text(announcement_title)
     end
 
-    it "should not allow a student to close/open announcement for comments or delete an announcement" do
+    it "should not allow a student to close/open announcement for comments or delete an announcement", priority: "1", test_id: 220377 do
       announcement_title = "Announcement 1"
       announcement = @course.announcements.create!(:title => announcement_title, :message => "Hey")
       get "/courses/#{@course.id}/announcements"
@@ -84,7 +84,7 @@
       expect(f('.discussion_actions ul.al-options')).to be_nil
     end
 
-    it "should allow a group member to create an announcement" do
+    it "should allow a group member to create an announcement", priority: "1", test_id: 220378 do
       gc = group_category
       group = gc.groups.create!(:context => @course)
       group.add_user(@student, 'accepted')
@@ -96,7 +96,7 @@
       }.to change(Announcement, :count).by 1
     end
 
-    it "should have deleted announcement removed from student account" do
+    it "should have deleted announcement removed from student account", priority: "1", test_id: 220379 do
       @announcement = @course.announcements.create!(:title => 'delete me', :message => 'Here is my message')
       get "/courses/#{@course.id}/announcements/"
       expect(f(".discussion-title")).to include_text('delete me')
@@ -105,7 +105,7 @@
       expect(f(".discussion-title")).to be_nil
     end
 
-    it "should remove notifications from unenrolled courses" do
+    it "should remove notifications from unenrolled courses", priority: "1", test_id: 220380 do
       enable_cache do
         @student.enrollments.first.update_attribute(:workflow_state, 'active')
         @course.announcements.create!(:title => 'Something', :message => 'Announcement time!')
@@ -117,4 +117,4 @@
       end
     end
   end
-end
+end

…c/selenium/announcements_teacher_spec.rb …ouncements/announcements_teacher_spec.rbspec/selenium/announcements_teacher_spec.rb renamed to spec/selenium/announcements/announcements_teacher_spec.rb spec/selenium/announcements_teacher_spec.rb renamed to spec/selenium/announcements/announcements_teacher_spec.rb

@@ -1,5 +1,5 @@
-require File.expand_path(File.dirname(__FILE__) + '/common')
-require File.expand_path(File.dirname(__FILE__) + '/helpers/announcements_common')
+require File.expand_path(File.dirname(__FILE__) + '/../common')
+require File.expand_path(File.dirname(__FILE__) + '/../helpers/announcements_common')
 
 describe "announcements" do
   include_examples "in-process server selenium tests"
@@ -23,7 +23,7 @@
         @checkboxes = ff('.toggleSelected')
       end
 
-      it "should bulk delete topics" do
+      it "should bulk delete topics", priority: "1", test_id: 220360 do
         5.times { |i| @checkboxes[i].click }
         f('#delete').click
         driver.switch_to.alert.accept
@@ -32,40 +32,40 @@
         expect(what_to_create.where(:workflow_state => 'active').count).to eq 0
       end
 
-      it "should bulk lock topics" do
+      it "should bulk lock topics", priority: "1", test_id: 220361 do
         5.times { |i| @checkboxes[i].click }
         f('#lock').click
         wait_for_ajax_requests
         #TODO: check the UI to make sure the topics have a locked symbol
         expect(what_to_create.where(:locked => true).count).to eq 5
       end
 
-      it "should search by title" do
+      it "should search by title", priority: "1", test_id: 150525 do
         expected_text = 'hey there'
         update_attributes_and_validate(:title, expected_text)
       end
 
-      it "should search by body" do
+      it "should search by body", priority: "1", test_id: 220358 do
         body_text = 'new topic body'
         update_attributes_and_validate(:message, body_text, 'topic')
       end
 
-      it "should search by author" do
+      it "should search by author", priority: "1", test_id: 220359 do
         user_name = 'jake@instructure.com'
         title = 'new one'
         new_teacher = teacher_in_course(:course => @course, :active_all => true, :name => user_name)
         what_to_create == DiscussionTopic ? @course.discussion_topics.create!(:title => title, :user => new_teacher.user) : announcement_model(:title => title, :user => new_teacher.user)
         refresh_and_filter(:string, 'jake', user_name)
       end
 
-      it "should return multiple items in the search" do
+      it "should return multiple items in the search", priority: "1", test_id: 220362 do
         new_title = 'updated'
         what_to_create.first.update_attributes(:title => "#{new_title} first")
         what_to_create.last.update_attributes(:title => "#{new_title} last")
         refresh_and_filter(:string, new_title, new_title, 2)
       end
 
-      it "should filter by unread" do
+      it "should filter by unread", priority: "1", test_id: 220363 do
         what_to_create.last.change_read_state('unread', @user)
         refresh_and_filter(:css, '#onlyUnread', 'new 004')
       end
@@ -80,7 +80,7 @@
         @context = @course
       end
 
-      it "should have a lock that appears and disappears when the cog menu is used to lock/unlock the announcement for comments" do
+      it "should have a lock that appears and disappears when the cog menu is used to lock/unlock the announcement for comments", priority: "1", test_id: 220365 do
         title = "My announcement"
         announcement_model(:title => title, :user => @user)
         get url
@@ -98,7 +98,7 @@
         expect(f('.discussion-info-icons .icon-lock')).to be_nil
       end
 
-      it "should remove an announcement when it is deleted from the delete option in the cog menu" do
+      it "should remove an announcement when it is deleted from the delete option in the cog menu", priority: "1", test_id: 220364 do
         title = "My announcement"
         announcement_model(:title => title, :user => @user)
         get url
@@ -113,14 +113,14 @@
         expect(f('.discussion-topic')).to be_nil
       end
 
-      it "should start a new topic" do
+      it "should start a new topic", priority: "1", test_id: 150528 do
         get url
 
         expect_new_page_load { f('.btn-primary').click }
         edit(@topic_title, 'new topic')
       end
 
-      it "should add an attachment to a new topic" do
+      it "should add an attachment to a new topic", priority: "1", test_id: 150529 do
         topic_title = 'new topic with file'
         get url
 
@@ -130,7 +130,7 @@
         expect(what_to_create.where(title: topic_title).first.attachment_id).to be_present
       end
 
-      it "should perform front-end validation for message" do
+      it "should perform front-end validation for message", priority: "1", test_id: 220366 do
         topic_title = 'new topic with file'
         get url
 
@@ -144,7 +144,7 @@
         expect(ff('.error_box').any?{|box| box.text.include?("A message is required")}).to be_truthy
       end
 
-      it "should add an attachment to a graded topic" do
+      it "should add an attachment to a graded topic", priority: "1", test_id: 220367 do
         what_to_create == DiscussionTopic ? @course.discussion_topics.create!(:title => 'graded attachment topic', :user => @user) : announcement_model(:title => 'graded attachment topic', :user => @user)
         if what_to_create == DiscussionTopic
           what_to_create.last.update_attributes(:assignment => @course.assignments.create!(:name => 'graded topic assignment'))
@@ -156,7 +156,7 @@
         add_attachment_and_validate
       end
 
-      it "should edit a topic" do
+      it "should edit a topic", priority: "1", test_id: 150530 do
         edit_name = 'edited discussion name'
         topic = what_to_create == DiscussionTopic ? @course.discussion_topics.create!(:title => @topic_title, :user => @user) : announcement_model(:title => @topic_title, :user => @user)
         get url + "#{topic.id}"
@@ -165,7 +165,7 @@
         edit(edit_name, 'edit message')
       end
 
-      it "should delete a topic" do
+      it "should delete a topic", priority: "1", test_id: 150526 do
         what_to_create == DiscussionTopic ? @course.discussion_topics.create!(:title => @topic_title, :user => @user) : announcement_model(:title => @topic_title, :user => @user)
         get url
 
@@ -177,7 +177,7 @@
         expect(f('.discussionTopicIndexList')).to be_nil
       end
 
-      it "should reorder topics" do
+      it "should reorder topics", priority: "1", test_id: 220368 do
         3.times { |i| what_to_create == DiscussionTopic ? @course.discussion_topics.create!(:title => "new topic #{i}", :user => @user) : announcement_model(:title => "new topic #{i}", :user => @user) }
         get url
 
@@ -192,7 +192,7 @@
       end
     end
 
-    it "should create a delayed announcement" do
+    it "should create a delayed announcement", priority: "1", test_id: 150531 do
       get course_announcements_path(@course)
       create_announcement_option('input[type=checkbox][name=delay_posting]')
       f('.ui-datepicker-trigger').click
@@ -202,7 +202,7 @@
       expect(f('.discussion-fyi')).to include_text('The content of this announcement will not be visible to users until')
     end
 
-    it "allows creating a delayed announcement with an attachment" do
+    it "allows creating a delayed announcement with an attachment", priority: "1", test_id: 220369 do
       get course_announcements_path(@course)
       create_announcement_option('input[type=checkbox][name=delay_posting]')
       f('.ui-datepicker-trigger').click
@@ -214,7 +214,7 @@
       expect(f('.discussion-fyi')).to include_text('The content of this announcement will not be visible to users until')
     end
 
-    it "should add and remove an external feed to announcements" do
+    it "should add and remove an external feed to announcements", priority: "1", test_id: 220370 do
       get "/courses/#{@course.id}/announcements"
 
       #add external feed to announcements
@@ -244,7 +244,7 @@
       }.to change(ExternalFeed, :count).by(-1)
     end
 
-    it "should remove delayed_post_at when unchecking delay_posting" do
+    it "should remove delayed_post_at when unchecking delay_posting", priority: "1", test_id: 220371 do
       topic = @course.announcements.create!(:title => @topic_title, :user => @user, :delayed_post_at => 10.days.ago, :message => "message")
       get "/courses/#{@course.id}/announcements/#{topic.id}"
       expect_new_page_load { f(".edit-btn").click }
@@ -256,7 +256,7 @@
       expect(topic.delayed_post_at).to be_nil
     end
 
-    it "should have a teacher add a new entry to its own announcement" do
+    it "should have a teacher add a new entry to its own announcement", priority: "1", test_id: 220372 do
       skip "delayed jobs"
       create_announcement
       get [@course, @announcement]
@@ -270,7 +270,7 @@
       expect(f('.topic_reply_count').text).to eq '1'
     end
 
-    it "should show announcements to student view student" do
+    it "should show announcements to student view student", priority: "1", test_id: 220373 do
       create_announcement
       enter_student_view
       get "/courses/#{@course.id}/announcements"
@@ -279,7 +279,7 @@
       expect(announcement.find_element(:css, '.discussion-summary')).to include_text(@announcement.message)
     end
 
-    it "should always see student replies when 'initial post required' is turned on" do
+    it "should always see student replies when 'initial post required' is turned on", priority: "1", test_id: 220374 do
       student_entry = 'this is my reply'
 
       create_announcement_initial
@@ -294,55 +294,5 @@
       get "/courses/#{@course.id}/discussion_topics/#{@announcement.id}"
       expect(ff('.discussion_entry .message')[1]).to include_text(student_entry)
     end
-
-    def setup_search()
-      create_announcement('day one', 'partridge')
-      create_announcement('day two', 'turtle doves')
-      create_announcement('day three', 'french hens')
-    end
-
-
-    # Search for an announcement by the content of the announcement
-    it "should search by body" do
-      setup_search
-      get "/courses/#{@course.id}/announcements/"
-      f('#searchTerm').send_keys('turtle')
-
-      # The keyword 'turtle' is in the body. Due to the layout of the html, it
-      #is more efficient to look for the title that matches the body
-      expect(f('.discussion-title')).not_to include_text("one")
-      expect(f('.discussion-title')).to include_text("two")
-      expect(f('.discussion-title')).not_to include_text("three")
-    end
-
-    # Search for an announcement by the title of the announcement
-    it "should search by title" do
-      setup_search
-      get "/courses/#{@course.id}/announcements/"
-      f('#searchTerm').send_keys('o')
-
-      #Two of our titles have an 'o' in them. There are two announcements
-      #so we store the ones we find in an array. Sorting algorithms will put
-      # "two" first and "one" second. We should not see three.
-      expect(ff('.discussion-title')[1]).to include_text("one")
-      expect(ff('.discussion-title')[0]).to include_text("two")
-      expect(f('.discussion-title')[2]).to be_nil #No 3rd one listed
-    end
-
-    # Search for an announcement by the author of the announcement
-    it "should search by author" do
-      setup_search
-      # Creating users through the rails function does not set an author.
-      # Manual setup is needed
-      create_announcement_manual("title 1", "jocoga")
-      create_announcement_manual("title 2", "hotdog")
-      get "/courses/#{@course.id}/announcements/"
-      f('#searchTerm').send_keys('nob')
-
-      # Only 2 of the 5 announcements will have an author
-      expect(ff('.discussion-author')[0]).to include_text("nobody")
-      expect(ff('.discussion-author')[1]).to include_text("nobody")
-      expect(ff('.discussion-author')[2]).to be_nil #No 3rd one listed
-    end
   end
-end
+end