fixes reading with external feeds

notifies the user through screen reader when an
external feed has been successfully deleted or
added

fixes CNVS-20801 CNVS-20799

test plan:
- navigate to the announcements page
- with screenreader on add a couple of external feeds
  (right side of page)
- with screen reader still on delete an added external feed
- notice the notification from screen reader.

Change-Id: I4dcc4831b7d43493e6f695f216d070dd5fe9fd78
Reviewed-on: https://gerrit.instructure.com/55624
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Tested-by: Jenkins
Product-Review: Aaron Cannon <acannon@instructure.com>

Author: sdb1228

app/coffeescripts/views/ExternalFeeds/IndexView.coffee

@@ -1,12 +1,14 @@
 define [
   'underscore'
+  'i18n!external_feeds'
   'compiled/views/ValidatedFormView'
   'compiled/models/ExternalFeed'
   'jst/ExternalFeeds/IndexView'
   'compiled/fn/preventDefault'
   'jquery'
   'jquery.toJSON'
-], (_, ValidatedFormView, ExternalFeed, template, preventDefault, $) ->
+  'compiled/jquery.rails_flash_notifications'
+], (_, I18n, ValidatedFormView, ExternalFeed, template, preventDefault, $) ->
 
   class IndexView extends ValidatedFormView
 
@@ -40,12 +42,14 @@ define [
 
     deleteFeed: preventDefault (event) ->
       id = @$(event.target).data('deleteFeedId')
-      @collection.get(id).destroy()
+      @collection.get(id).destroy success: ->
+        $.screenReaderFlashMessage(I18n.t('External feed was deleted'))
 
     getFormData: ->
       @$('#add_external_feed_form').toJSON()
 
     onSaveSuccess: =>
       super
+      $.screenReaderFlashMessage(I18n.t('External feed was added'))
       @collection.add(@model)
       @createPendingModel()

spec/coffeescripts/views/ExternalFeeds/IndexViewSpec.coffee

@@ -9,20 +9,22 @@ define [
   module 'IndexView',
     setup: ->
       fakeENV.setup(context_asset_string: 'courses_1')
+      $('#fixtures').append($("<div>").attr('id', 'feed_container'))
       ef = new ExternalFeed
         id: 1
         url: 'http://www.example.com/feed'
         display_name: 'Example Feed'
         verbosity: 'link_only'
         header_match: null
       efc = new ExternalFeedCollection [ef]
-      view = new ExternalFeedsIndexView
-        el: '#fixtures'
+      @view = new ExternalFeedsIndexView
+        el: '#feed_container'
         permissions: { create: true }
         collection: efc
-      view.render()
+      @view.render()
 
     teardown: ->
+      @view.remove()
       $('#fixtures').empty()
       fakeENV.teardown()
 
@@ -32,12 +34,51 @@ define [
     $('#external_feed_verbosity').val('link_only')
     $('#add_external_feed_form button').click()
 
+
+
   test 'renders the list of feeds', ->
     equal $('li.external_feed').length, 1
     ok $('li.external_feed').text().match('Example Feed')
 
+
   # TODO: These specs are failing intermittantly and I can't figure out why,
   # but it's not worth the build being super fragile
+
+
+  # test 'add external feed is read by screenreader', ->
+  #   @spy($, 'screenReaderFlashMessage')
+  #   server = sinon.fakeServer.create()
+  #   server.respondWith('POST', '/api/v1/courses/1/external_feeds',
+  #     [200, { 'Content-Type': 'application/json' }, JSON.stringify({
+  #       id: 2
+  #       url: 'http://www.example.com/feed2'
+  #       display_name: 'Other Feed'
+  #       verbosity: 'link_only'
+  #       header_match: null
+  #     })])
+
+  #   submitForm('http://www.example.com/feed2')
+  #   server.respond()
+  #   equal $.screenReaderFlashMessage.callCount, 1
+  #   server.restore()
+
+  # test 'delete external feed is read by screenreader', ->
+  #   @spy($, 'screenReaderFlashMessage')
+  #   server = sinon.fakeServer.create()
+  #   server.respondWith('POST', '/api/v1/courses/1/external_feeds',
+  #     [200, { 'Content-Type': 'application/json' }, JSON.stringify({
+  #       id: 3
+  #       url: 'http://www.example.com/feed2'
+  #       display_name: 'Other Feed'
+  #       verbosity: 'link_only'
+  #       header_match: null
+  #     })])
+
+  #   submitForm('http://www.example.com/feed2')
+  #   server.respond()
+  #   $('.close').first().click()
+  #   equal $.screenReaderFlashMessage.callCount, 1
+
   # test 'allows adding a new feed', ->
   #   server = sinon.fakeServer.create()
   #   server.respondWith('POST', '/api/v1/courses/1/external_feeds',