Skip to content

Commit ff9014f

Browse files
ryankshawzwily
authored andcommitted
fix media comments for discussions with tons of videos
if you called $().mediaCommentThumbnail() with an empty set it would break it so it won't make mediaCommentThumbails any more for anything else. Change-Id: I1a8868439563df7655c07d1aedfada37ad4db857 fixes: #8874 Reviewed-on: https://gerrit.instructure.com/11522 Reviewed-by: Zach Wily <zach@instructure.com> Tested-by: Zach Wily <zach@instructure.com>
1 parent 21ad2b5 commit ff9014f

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

public/javascripts/media_comments.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,6 @@ define([
146146
var thumbnailsQueued = [];
147147
var thumbnailing = false;
148148
var nextThumbnail = function() {
149-
if (!thumbnailsQueued.length) return; // shortcut if there's no work to do
150149
thumbnailing = true;
151150
var iterations = Math.min(thumbnailsQueued.length, 30),
152151
thumbnail;

0 commit comments

Comments
 (0)