dom/event: add delegate event support; improve stablility of funtion overloading of .off() method; fix a bug when trying to dispatch a live event;

Author: Kael

lib/event/live.js

@@ -119,6 +119,7 @@ function dispatch(event, type){
         handlers = storage[type];
 
     // avoid non-left-click bubbling in Firefox (#3861)
+    // TODO:
     if (event.button && type === 'click' || !handlers || !handlers.length){
         return;
     }
@@ -142,9 +143,9 @@ function dispatch(event, type){
 
     // delegate events needs element traversing which takes huge costs, 
     // so check them first 
-    if(live){
+    if(live && event){
         for(cur = event.target; cur && cur !== el; cur = cur.parentNode){
-            for(i = 0; i <= live; i ++ ){
+            for(i = 0; i < live; i ++ ){
                 handler = handlers[i];
 
                 if(
@@ -155,15 +156,15 @@ function dispatch(event, type){
 
                     (!condition || condition.call(cur, event))
                 ){
-                    if(handler.fn.call(cur, event)){
+                    if(handler.fn.call(cur, event) === false){
                         event.stop();
                     };
                 }
             }
         }
     }
 
-    for(i = live + 1, len = handlers.length; i < len; i ++){
+    for(i = live, len = handlers.length; i < len; i ++){
         handler = handlers[i];
 
         if(!condition || condition.call(self, event)){
@@ -285,7 +286,7 @@ function addDOMEvent(el, type, selector, fn){
  * .off(type, selector)                     -> remove all delegated events which match the selector
  * .off(type, selector, fn)                 -> remove a live event handler
  * .off(type, '**')                         -> remove all live <type> events
- * .off(type, '**', fn)                         -> remove all live <type> events
+ * .off(type, '**', fn)                     -> remove all live <type> events
  
  * .off(type-map)                           -> remove several events
  * .off(type-map, selector)                 -> remove several live events
@@ -429,6 +430,9 @@ function removeDOMEvent(el, type, selector, fn){
                         selector === false || selector === STR_WILD_SELECTORS || selector === handler.selector
                     )
 
+                    // reduce handlers.live
+                    && handlers.live --
+                    
                     || !handler.selector && selector === undef
                 )
             ){
@@ -438,6 +442,7 @@ function removeDOMEvent(el, type, selector, fn){
 
         if(!handlers.length){
             removeEvent(el, handlers.base, handlers.handle, handlers.capture);
+            delete storage[type];
         }
     }
 };
@@ -637,11 +642,11 @@ event_storage._clean = function(id){
 
 DOM.extend({
     on  : overloadAddEventArguments,
-    off : overloadRemoveEventArguments,
+    off : overloadRemoveEventArguments //,
 
     /**
      * fire an event
-     */
+     
     fire: function(type){
         var el = this,
             storage = getStorage(el);
@@ -652,6 +657,7 @@ DOM.extend({
             });
         }
     }
+    */
 
 }, 'iterator');
 
@@ -665,6 +671,11 @@ DOM.Events = Events;
 /**
  change log:
  
+ 2012-08-04  Kael:
+ - add delegate event support
+ - improve stablility of funtion overloading of .off() method
+ - fix a bug when trying to dispatch a live event
+ 
  2012-05-02  Kael:
  - fix mousewheel event for firefox