Skip to content
This repository was archived by the owner on Jan 27, 2019. It is now read-only.

Commit 3334e56

Browse files
committed
extract check into function
1 parent c015fa7 commit 3334e56

File tree

1 file changed

+15
-6
lines changed

1 file changed

+15
-6
lines changed

index.js

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
var q = require('q');
44
var isCss = require('is-css');
5-
var isBlank = require('is-blank')
6-
var isUrl = require('is-url-superb')
5+
var isBlank = require('is-blank');
6+
var isUrl = require('is-url-superb');
77
var request = require('request');
88
var cheerio = require('cheerio');
99
var normalizeUrl = require('normalize-url');
@@ -55,12 +55,11 @@ module.exports = function(url, options){
5555
result.pageTitle = $('head > title').text();
5656

5757
$('[rel=stylesheet]').each(function() {
58-
var link = $(this).attr('href');
59-
if (!(typeof link !== typeof undefined && link !== false)) {
58+
if(isHrefPresent(this)) {
59+
result.links.push(createLink(link, url));
60+
}else{
6061
result.styles.push(stripHtmlComments($(this).text()));
61-
return;
6262
}
63-
result.links.push(createLink(link, url));
6463
});
6564

6665
$('style').each(function() {
@@ -100,6 +99,16 @@ module.exports = function(url, options){
10099
handleResolve();
101100
}
102101

102+
/**
103+
* check if the link object is a valid resouce link
104+
* @param link
105+
*/
106+
function isHrefPresent ( link ) {
107+
var href = $(link).attr('href');
108+
return (typeof href !== typeof undefined && href !== false);
109+
}
110+
111+
103112
// Handle potential @import url(foo.css) statements in the CSS.
104113
function parseCssForImports(link, css) {
105114
link.imports = resolveCssImportUrls(link.url, css);

0 commit comments

Comments
 (0)