Skip to content

Commit 2ca2398

Browse files
add authoring guidelines (#631)
* add authoring guidelines * Update AUTHORING_GUIDELINES.md Co-authored-by: Antonio Laguna <sombragriselros@gmail.com> Co-authored-by: Antonio Laguna <sombragriselros@gmail.com>
1 parent 8ec3046 commit 2ca2398

File tree

5 files changed

+23
-8
lines changed

5 files changed

+23
-8
lines changed

AUTHORING_GUIDELINES.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# Authoring guidelines
2+
3+
We want to make it easier to write awesome CSS that works great in as many browsers as possible.
4+
Some of these browsers are a bit older, others don't yet exist.
5+
6+
We will not place undue burden on anyone writing or maintaining CSS.
7+
8+
We will only add a plugin to `postcss-preset-env` when the CSS WG invites implementations for the relevant features.
9+
10+
We will not create plugins with features (or add features to plugins) that look and feel native but don't have a specification.
11+
12+
We will make it clear that non-standard, pre-processor features are just that.
13+
14+
We will only implement that which we know is correct and avoid side effects.

CONTRIBUTING.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ instructions:
2626
### Quick start
2727

2828
1. fork the repo and clone it locally
29-
2. `npm run get-me-going` to install and build dependencies
29+
2. `npm run setup-workspace` to install and build dependencies
3030
3. `cd plugins/<plugin-name>`
3131
4. `npm run build && npm run test` to build and test the plugin after making changes
3232
5. open a pull request with the changes
@@ -58,7 +58,7 @@ Receiving early feedback on your work will help you iterate more quickly in the
5858
# Install and build the needed things to start local development
5959
# This also does an initial test of everything.
6060
# If this gives errors please open an issue so that we can look into it.
61-
npm run get-me-going
61+
npm run setup-workspace
6262
```
6363

6464
* If you want to contribute to sites, you need to run the following command:
@@ -67,7 +67,7 @@ Receiving early feedback on your work will help you iterate more quickly in the
6767
cd sites
6868
# Install the needed things to start local development
6969
# If this gives errors please open an issue so that we can look into it.
70-
npm run get-me-going
70+
npm run setup-workspace
7171
```
7272

7373
3. Create a branch for your feature or fix:
@@ -111,7 +111,7 @@ That’s it! Now [open a pull request] with a clear title and description.
111111
## Creating a new plugin here
112112

113113
- Follow the guide for submitting a pull request
114-
- Run `npm run get-me-going` if you want to start local development.
114+
- Run `npm run setup-workspace` if you want to start local development.
115115
- Run `npm run new-plugin` to create a new plugin.
116116

117117
```bash
@@ -147,7 +147,8 @@ Change "blue" to "purple" in "src/index.ts" and see how it affects the test outc
147147

148148
- [PostCSS API documentation](https://postcss.org/api/)
149149
- [PostCSS guidelines for plugins](https://github.com/postcss/postcss/blob/main/docs/guidelines/plugin.md)
150-
- [CSSTools guidelines for plugins](https://github.com/csstools/postcss-plugins/wiki/Plugin-best-practices)
150+
- [CSSTools technical guidelines for plugins](https://github.com/csstools/postcss-plugins/wiki/Plugin-best-practices)
151+
- [CSSTools authoring guidelines](https://github.com/csstools/postcss-plugins/blob/main/AUTHORING_GUIDELINES.md)
151152

152153
## Trouble shooting
153154

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
"scripts": {
3535
"build": "npm run build --workspaces --if-present",
3636
"clean": "bash ./.github/bin/clean.sh",
37-
"get-me-going": "npm run clean && npm ci && npm run build && npm run test",
37+
"setup-workspace": "npm run clean && npm ci && npm run build && npm run test",
3838
"docs": "npm run docs --workspaces --if-present",
3939
"lint": "npm run lint --workspaces --if-present && npm run lint:rollup-config && npm run lint:executable-files && npm run lint:licenses",
4040
"lint:executable-files": "bash .github/bin/detect-executable-files/detect-executable-files.sh",

sites/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
},
1818
"scripts": {
1919
"clean": "git clean -dfx",
20-
"get-me-going": "npm run clean && npm i",
20+
"setup-workspace": "npm run clean && npm i",
2121
"build": "npm run build --workspaces --if-present",
2222
"lint": "npm run lint --workspaces --if-present",
2323
"start": "npm run build --workspaces --if-present"

sites/postcss-preset-env/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Before you can contribute to the codebase, you will need to fork the repo.
1616

1717
# Install the needed things to start local development
1818
# If this gives errors please open an issue so that we can look into it.
19-
npm run get-me-going
19+
npm run setup-workspace
2020
```
2121

2222
This site is built using the following awesome packages:

0 commit comments

Comments
 (0)