housekeeping after migration (#431)

* houskeeping after migration

* fix

* add check for file permissions

* fix

* fix

* fix

Author: romainmenke

.github/bin/detect-executable-files/detect-executable-files.sh

@@ -0,0 +1,10 @@
+#!/usr/bin/env bash
+set -e
+
+if [ "$(uname)" == "Darwin" ]; then
+  # Darwin cmd
+  find . -type f -perm +0111 | node .github/bin/detect-executable-files/to-github-annotations.js
+else
+  # Linux cmd
+  find . -type f -perm /u=x,g=x,o=x | node .github/bin/detect-executable-files/to-github-annotations.js
+fi

.github/bin/detect-executable-files/to-github-annotations.js

@@ -0,0 +1,85 @@
+const fs = require('fs');
+const data = fs.readFileSync(0, 'utf-8');
+let fileNames = data.split(/\r?\n/);
+
+const allowList = [];
+
+fileNames = fileNames.filter((f) => {
+	if (0 === f.length) {
+		return false; // trailing newline
+	}
+
+	if (f.includes('node_modules')) {
+		return false; // node_modules folders are not distributed
+	}
+
+	if (f.startsWith('./.git/')) {
+		return false; // git stuffs
+	}
+
+	if (f.startsWith('./.github/')) {
+		return false; // these are not distributed
+	}
+
+	if (f.endsWith('dist/cli.cjs')) {
+		return false; // this is expected to be executable
+	}
+
+	return !allowList.includes(f);
+});
+
+if (!fileNames || !fileNames.length) {
+	process.exit(0);
+}
+
+if (!process.env.GITHUB_ACTIONS) {
+	console.log(`Unexpected executables:`);
+	fileNames.forEach((f) => {
+		console.log(`chmod a-x ${f}`);
+	});
+	process.exit(1);
+}
+
+fileNames.forEach((f) => {
+	const annotation = formatGitHubActionAnnotation(
+		`This file is unexpectedly executable`,
+		'error',
+		{
+			file: f,
+			line: 1,
+			col: 1,
+		}
+	);
+
+	console.log(annotation);
+});
+
+process.exit(1);
+
+function formatGitHubActionAnnotation(message, level = 'error', options = {}) {
+	let output = '::' + level;
+
+	const outputOptions = Object.keys(options)
+		.map((key) => {
+			return `${key}=${escape(String(options[key]))}`;
+		})
+		.join(',');
+
+	if (outputOptions) {
+		output += ` ${outputOptions}`;
+	}
+
+	return `${output}::${escapeData(message || '')}`;
+}
+
+function escapeData(s) {
+	return s.replace(/\r/g, '%0D').replace(/\n/g, '%0A');
+}
+
+function escape(s) {
+	return s
+		.replace(/\r/g, '%0D')
+		.replace(/\n/g, '%0A')
+		.replace(/]/g, '%5D')
+		.replace(/;/g, '%3B');
+}

.github/workflows/test-in-browser.yml

@@ -19,6 +19,6 @@ jobs:
           node-version: 16
 
       - run: npm ci
-      - run: npm run build --workspaces --if-present
-      - run: npm run --silent test:browser --workspaces --if-present
+      - run: npm run build --if-present
+      - run: npm run test:browser --if-present
 

.github/workflows/test.yml

@@ -39,20 +39,20 @@ jobs:
         # - with exact dependencies from package-lock.json
         # - without requiring postinstall scripts from dependencies to run
       - run: npm ci --ignore-scripts
-      - run: npm run build --workspaces --if-present
-      - run: npm run lint --workspaces --if-present
+      - run: npm run build
+      - run: npm run lint
         if: matrix.is_base_node_version && matrix.is_base_os_version
 
         # PostCSS Tape tests
-      - run: npm run test --workspaces --if-present
+      - run: npm run test
         env:
           ENABLE_ANNOTATIONS_FOR_NODE: ${{ matrix.is_base_node_version }}
           ENABLE_ANNOTATIONS_FOR_OS: ${{ matrix.is_base_os_version }}
 
         # CLI Tests
         # running "npm install" places the cli in node_modules/bin
       - run: npm install --ignore-scripts
-      - run: npm run --silent test:cli --workspace="@csstools/postcss-base-plugin"
+      - run: npm run test:cli --workspace="@csstools/postcss-base-plugin"
 
   # Run e2e tests
   test_e2e:
@@ -64,17 +64,17 @@ jobs:
           node-version: 16
 
       - run: npm ci --ignore-scripts
-      - run: npm run build --workspaces --if-present
+      - run: npm run build
 
       # Webpack compatibility
       - run: |
             cd e2e/webpack/bundle-through
             npm install
             npm run build
-            npm run --silent test
+            npm run test
 
       # Deno compatibility
       - uses: denoland/setup-deno@v1
         with:
           deno-version: v1.x.x
-      - run: npm run --silent test:deno --workspaces --if-present
+      - run: npm run test:deno --workspaces --if-present

package.json

@@ -35,11 +35,13 @@
 		"clean": "bash ./.github/bin/clean.sh",
 		"get-me-going": "npm run clean && npm ci && npm run build && npm run test",
 		"docs": "npm run docs --workspaces --if-present",
-		"lint": "npm run lint --workspaces --if-present && npm run lint:rollup-config",
+		"lint": "npm run lint --workspaces --if-present && npm run lint:rollup-config && npm run lint:executable-files",
+		"lint:executable-files": "bash .github/bin/detect-executable-files/detect-executable-files.sh",
 		"lint:rollup-config": "eslint ./rollup --ext .js --ext .ts --ext .mjs --no-error-on-unmatched-pattern",
 		"new-plugin": "node ./.github/bin/new-plugin.mjs",
 		"prepare-repo-for-releases": "npm run clean && npm ci && npm run docs && npm run lint && npm run build && npm run test && bash ./.github/bin/fail-on-changes.sh",
-		"test": "npm run test --workspaces --if-present"
+		"test": "npm run test --workspaces --if-present",
+		"test:browser": "npm run test:browser --workspaces --if-present"
 	},
 	"volta": {
 		"node": "16.13.1",

packages/generate-test-cases/src/index.mjs

@@ -78,6 +78,14 @@ import { generate } from './generate.mjs';
 				],
 			),
 
+			generate(
+				'value',
+				path.join('../../plugins', 'postcss-color-rebeccapurple'),
+				[
+					'rebeccapurple',
+				],
+			),
+
 			generate(
 				'declaration',
 				path.join('../../plugins', 'postcss-place'),

packages/generate-test-cases/src/value.mjs

@@ -5,6 +5,12 @@ export function generateValueTestCases(value) {
 	values.push(`var(1, ${value})`);
 	values.push(`var(${value}, 1)`);
 	values.push(`var(${value}, ${value})`);
+	values.push(`pre${value}`);
+	values.push(`pre ${value}`);
+	values.push(`pre,${value}`);
+	values.push(`${value}post`);
+	values.push(`${value} post`);
+	values.push(`${value},post`);
 
 	let result = values.map((x, index) => {
 		return `.order-${index} {

plugins/postcss-base-plugin/package.json

@@ -42,7 +42,7 @@
 		"dist"
 	],
 	"peerDependencies": {
-		"postcss": "^8.3"
+		"postcss": "^8.4"
 	},
 	"scripts": {
 		"build": "rollup -c ../../rollup/default.js",

plugins/postcss-color-functional-notation/test/generated-value-cases.css

@@ -14,6 +14,30 @@
 	order: var(rgba(178 34 34 / 1), rgba(178 34 34 / 1));
 }
 
+.order-4 {
+	order: prergba(178 34 34 / 1);
+}
+
+.order-5 {
+	order: pre rgba(178 34 34 / 1);
+}
+
+.order-6 {
+	order: pre,rgba(178 34 34 / 1);
+}
+
+.order-7 {
+	order: rgba(178 34 34 / 1)post;
+}
+
+.order-8 {
+	order: rgba(178 34 34 / 1) post;
+}
+
+.order-9 {
+	order: rgba(178 34 34 / 1),post;
+}
+
 /* rgba(178 34 34 / 1) */
 
 :root {
@@ -46,6 +70,30 @@
 	order: var(hsl(120 100% 50% / 1), hsl(120 100% 50% / 1));
 }
 
+.order-4 {
+	order: prehsl(120 100% 50% / 1);
+}
+
+.order-5 {
+	order: pre hsl(120 100% 50% / 1);
+}
+
+.order-6 {
+	order: pre,hsl(120 100% 50% / 1);
+}
+
+.order-7 {
+	order: hsl(120 100% 50% / 1)post;
+}
+
+.order-8 {
+	order: hsl(120 100% 50% / 1) post;
+}
+
+.order-9 {
+	order: hsl(120 100% 50% / 1),post;
+}
+
 /* hsl(120 100% 50% / 1) */
 
 :root {

plugins/postcss-color-functional-notation/test/generated-value-cases.expect.css

@@ -14,6 +14,30 @@
 	order: var(rgba(178, 34, 34, 1), rgba(178, 34, 34, 1));
 }
 
+.order-4 {
+	order: prergba(178 34 34 / 1);
+}
+
+.order-5 {
+	order: pre rgba(178, 34, 34, 1);
+}
+
+.order-6 {
+	order: pre,rgba(178, 34, 34, 1);
+}
+
+.order-7 {
+	order: rgba(178, 34, 34, 1)post;
+}
+
+.order-8 {
+	order: rgba(178, 34, 34, 1) post;
+}
+
+.order-9 {
+	order: rgba(178, 34, 34, 1),post;
+}
+
 /* rgba(178 34 34 / 1) */
 
 :root {
@@ -46,6 +70,30 @@
 	order: var(hsla(120, 100%, 50%, 1), hsla(120, 100%, 50%, 1));
 }
 
+.order-4 {
+	order: prehsl(120 100% 50% / 1);
+}
+
+.order-5 {
+	order: pre hsla(120, 100%, 50%, 1);
+}
+
+.order-6 {
+	order: pre,hsla(120, 100%, 50%, 1);
+}
+
+.order-7 {
+	order: hsla(120, 100%, 50%, 1)post;
+}
+
+.order-8 {
+	order: hsla(120, 100%, 50%, 1) post;
+}
+
+.order-9 {
+	order: hsla(120, 100%, 50%, 1),post;
+}
+
 /* hsl(120 100% 50% / 1) */
 
 :root {