reduce npm run invocations (#893)

* reduce npm run invocations

* remove more invocations

* run eslint once for the entire repo

* fix

* fix

Author: romainmenke

.eslintrc.json

@@ -8,6 +8,7 @@
 		"ecmaVersion": 2022,
 		"sourceType": "module"
 	},
+	"ignorePatterns": ["**/dist/*"],
 	"rules": {
 		"quotes": ["error", "single"],
 		"comma-dangle": ["error", "always-multiline"],
@@ -21,7 +22,9 @@
 	"overrides": [
 		{
 			"files": [
-				"**/*.ts"
+				"**/*.ts",
+				"**/*.mts",
+				"**/*.cts"
 			],
 			"extends": [
 				"plugin:@typescript-eslint/eslint-recommended",

.github/bin/clean.sh

@@ -0,0 +1,38 @@
+name: lint
+on:
+  push:
+    branches:
+    - 'main'
+  pull_request:
+  workflow_dispatch:
+    inputs:
+      build_and_test_all_packages:
+        type: boolean
+        description: Lint all packages
+        required: true
+
+concurrency:
+  group: branch-node--lint--${{ github.ref }}
+  cancel-in-progress: true
+
+defaults:
+  run:
+    shell: bash
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          fetch-depth: 1
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 18
+
+      - name: npm ci
+        run: |
+          npm ci --ignore-scripts
+
+      - name: lint
+        run: npm run lint

.github/workflows/lint.yml

@@ -12,7 +12,7 @@ on:
         required: true
 
 concurrency:
-  group: branch-node-${{ github.ref }}
+  group: branch-node--test--${{ github.ref }}
   cancel-in-progress: true
 
 defaults:
@@ -66,18 +66,14 @@ jobs:
           GITHUB_ACTION_PULL_REQUEST_NUMBER: ${{ github.event.pull_request.number }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
-        # Build, lint and PostCSS Tape tests must all work and pass :
+        # Build and PostCSS Tape tests must all work and pass :
         # - with exact dependencies from package-lock.json
         # - without requiring postinstall scripts from dependencies to run
       - name: build
         run: |
           npm run build --if-present $MODIFIED_WORKSPACES
         if: matrix.is_base_node_version && matrix.is_base_os_version
 
-      - name: lint
-        run: npm run lint --if-present $MODIFIED_WORKSPACES
-        if: matrix.is_base_node_version && matrix.is_base_os_version
-
       - name: docs
         run: npm run docs --if-present $MODIFIED_WORKSPACES
         if: matrix.is_base_node_version && matrix.is_base_os_version

.github/workflows/test.yml

@@ -76,16 +76,11 @@
 		"@csstools/base-cli": "0.1.0"
 	},
 	"scripts": {
-		"prebuild": "npm run clean",
 		"build": "rollup -c ../../rollup/default.mjs && npm run set-cli-file-permissions",
-		"clean": "node -e \"fs.rmSync('./dist', { recursive: true, force: true }); fs.mkdirSync('./dist');\"",
 		"csstools-cli": "csstools-cli",
-		"lint": "npm run lint:eslint && npm run lint:package-json",
-		"lint:eslint": "eslint ./src --ext .js --ext .ts --ext .mjs --no-error-on-unmatched-pattern",
-		"lint:package-json": "node ../../.github/bin/format-package-json.mjs",
-		"prepublishOnly": "npm run clean && npm run build && npm run test",
+		"lint": "node ../../.github/bin/format-package-json.mjs",
+		"prepublishOnly": "npm run build && npm run test",
 		"set-cli-file-permissions": "chmod a+x ./dist/cli.cjs",
-		"stryker": "stryker run --logLevel error",
 		"test": "exit 0",
 		"test:cli": "bash ./test/cli/test.sh"
 	},

cli/csstools-cli/package.json

@@ -4,8 +4,8 @@
 	"private": true,
 	"description": "Can you use custom-media, design-tokens and global-data together?",
 	"scripts": {
-		"build": "postcss style.css -o ./result.css",
-		"watch": "postcss style.css -w -o ./result.css",
+		"build": "postcss style.css -o ./dist/result.css",
+		"watch": "postcss style.css -w -o ./dist/result.css",
 		"test": "node ./test.mjs"
 	},
 	"devDependencies": {

cli/csstools-cli/stryker.conf.json

@@ -1,7 +1,7 @@
 import assert from 'assert';
 import fs from 'fs/promises';
 
-const result = await fs.readFile('./result.css');
+const result = await fs.readFile('./dist/result.css');
 const expect = await fs.readFile('./expect.css');
 
 assert.equal(result.toString(), expect.toString());