Skip to content

Commit afb4c98

Browse files
committed
Simplify range convenience function tests.
1 parent fe89724 commit afb4c98

File tree

1 file changed

+20
-29
lines changed

1 file changed

+20
-29
lines changed

test/jquery-ui-timepicker-addon_spec.js

Lines changed: 20 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -312,42 +312,33 @@ describe('datetimepicker', function() {
312312
});
313313
});
314314

315-
describe('timeRange', function() {
316-
it('calls handleRange the right way', function() {
317-
var startTime = new Date(),
318-
endTime = new Date(),
319-
options = {};
320-
spyOn($.timepicker, 'handleRange');
315+
describe('range functions', function() {
316+
var startTime = $('<p>start</p>'),
317+
endTime = $('<p>end</p>'),
318+
options = {};
321319

322-
$.timepicker.timeRange(startTime, endTime, options);
320+
describe('convenience functions', function() {
321+
beforeEach(function() {
322+
spyOn($.timepicker, 'handleRange');
323+
});
323324

324-
expect($.timepicker.handleRange).toHaveBeenCalledWith('timepicker', startTime, endTime, options);
325-
});
326-
});
327-
328-
describe('datetimeRange', function() {
329-
it('calls handleRange the right way', function() {
330-
var startTime = new Date(),
331-
endTime = new Date(),
332-
options = {};
333-
spyOn($.timepicker, 'handleRange');
325+
it('timeRange calls handleRange the right way', function() {
326+
$.timepicker.timeRange(startTime, endTime, options);
334327

335-
$.timepicker.datetimeRange(startTime, endTime, options);
328+
expect($.timepicker.handleRange).toHaveBeenCalledWith('timepicker', startTime, endTime, options);
329+
});
336330

337-
expect($.timepicker.handleRange).toHaveBeenCalledWith('datetimepicker', startTime, endTime, options);
338-
});
339-
});
331+
it('datetimeRange calls handleRange the right way', function() {
332+
$.timepicker.datetimeRange(startTime, endTime, options);
340333

341-
describe('dateRange', function() {
342-
it('calls handleRange the right way', function() {
343-
var startTime = new Date(),
344-
endTime = new Date(),
345-
options = {};
346-
spyOn($.timepicker, 'handleRange');
334+
expect($.timepicker.handleRange).toHaveBeenCalledWith('datetimepicker', startTime, endTime, options);
335+
});
347336

348-
$.timepicker.dateRange(startTime, endTime, options);
337+
it('dateRange calls handleRange the right way', function() {
338+
$.timepicker.dateRange(startTime, endTime, options);
349339

350-
expect($.timepicker.handleRange).toHaveBeenCalledWith('datepicker', startTime, endTime, options);
340+
expect($.timepicker.handleRange).toHaveBeenCalledWith('datepicker', startTime, endTime, options);
341+
});
351342
});
352343
});
353344
});

0 commit comments

Comments
 (0)