Skip to content

Commit f50fc08

Browse files
committed
Refactor splitDateTime() signature to eliminate two unused parameters.
1 parent 6adc077 commit f50fc08

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

jquery-ui-timepicker-addon.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1832,7 +1832,7 @@
18321832
* Throws exception when date can't be parsed
18331833
* Returns {dateString: dateString, timeString: timeString}
18341834
*/
1835-
var splitDateTime = function(dateFormat, dateTimeString, dateSettings, timeSettings) {
1835+
var splitDateTime = function(dateTimeString, timeSettings) {
18361836
// The idea is to get the number separator occurrences in datetime and the time format requested (since time has
18371837
// fewer unknowns, mostly numbers and am/pm). We will use the time pattern to split.
18381838
var separator = computeEffectiveSetting(timeSettings, 'separator'),
@@ -1866,7 +1866,7 @@
18661866
parts,
18671867
parsedTime;
18681868

1869-
parts = splitDateTime(dateFormat, dateTimeString, dateSettings, timeSettings);
1869+
parts = splitDateTime(dateTimeString, timeSettings);
18701870
date = $.datepicker._base_parseDate(dateFormat, parts.dateString, dateSettings);
18711871

18721872
if (parts.timeString === '') {

test/jquery-ui-timepicker-addon_spec.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ describe('datetimepicker', function() {
230230
var inputDateTimeString = expectedDateString + $.timepicker._defaults.separator + expectedTimeString,
231231
result;
232232

233-
result = $.timepicker._util._splitDateTime('', inputDateTimeString, {}, {});
233+
result = $.timepicker._util._splitDateTime(inputDateTimeString, {});
234234

235235
expect(result).toEqual({dateString: expectedDateString, timeString: expectedTimeString});
236236
});
@@ -240,7 +240,7 @@ describe('datetimepicker', function() {
240240
inputDateTimeString = expectedDateString + separator + expectedTimeString,
241241
result;
242242

243-
result = $.timepicker._util._splitDateTime('', inputDateTimeString, {}, {separator: separator});
243+
result = $.timepicker._util._splitDateTime(inputDateTimeString, {separator: separator});
244244

245245
expect(result).toEqual({dateString: expectedDateString, timeString: expectedTimeString});
246246
});
@@ -253,13 +253,13 @@ describe('datetimepicker', function() {
253253
timeSettings = {separator: separator, timeFormat: timeFormat},
254254
result;
255255

256-
result = $.timepicker._util._splitDateTime('', inputDateTimeString, {}, timeSettings);
256+
result = $.timepicker._util._splitDateTime(inputDateTimeString, timeSettings);
257257

258258
expect(result).toEqual({dateString: expectedDateString, timeString: alternateTimeString});
259259
});
260260

261261
it('splits only a date into itself', function() {
262-
var result = $.timepicker._util._splitDateTime('', expectedDateString, {}, {});
262+
var result = $.timepicker._util._splitDateTime(expectedDateString, {});
263263

264264
expect(result).toEqual({dateString: expectedDateString, timeString: ''});
265265
});

0 commit comments

Comments
 (0)