Fix even more Rx dispose logic.

Author: dbrant

app/src/main/java/fr/free/nrw/commons/explore/images/SearchImageFragment.java

@@ -4,7 +4,6 @@
 import android.annotation.SuppressLint;
 import android.content.res.Configuration;
 import android.os.Bundle;
-import android.os.Handler;
 import androidx.recyclerview.widget.GridLayoutManager;
 import androidx.recyclerview.widget.LinearLayoutManager;
 import androidx.recyclerview.widget.RecyclerView;
@@ -142,12 +141,12 @@ public void updateImageList(String query) {
         bottomProgressBar.setVisibility(GONE);
         queryList.clear();
         imagesAdapter.clear();
-        okHttpJsonApiClient.searchImages(query, queryList.size())
+        compositeDisposable.add(okHttpJsonApiClient.searchImages(query, queryList.size())
                 .subscribeOn(Schedulers.io())
                 .observeOn(AndroidSchedulers.mainThread())
                 .timeout(TIMEOUT_SECONDS, TimeUnit.SECONDS)
                 .doOnSubscribe(disposable -> saveQuery(query))
-                .subscribe(this::handleSuccess, this::handleError);
+                .subscribe(this::handleSuccess, this::handleError));
     }
 
 
@@ -159,11 +158,11 @@ public void addImagesToList(String query) {
         this.query = query;
         bottomProgressBar.setVisibility(View.VISIBLE);
         progressBar.setVisibility(GONE);
-        okHttpJsonApiClient.searchImages(query, queryList.size())
+        compositeDisposable.add(okHttpJsonApiClient.searchImages(query, queryList.size())
                 .subscribeOn(Schedulers.io())
                 .observeOn(AndroidSchedulers.mainThread())
                 .timeout(TIMEOUT_SECONDS, TimeUnit.SECONDS)
-                .subscribe(this::handlePaginationSuccess, this::handleError);
+                .subscribe(this::handlePaginationSuccess, this::handleError));
     }
 
     /**

app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java

@@ -420,15 +420,15 @@ public void onDeleteButtonClicked(){
     private void onDeleteClicked(Spinner spinner) {
         String reason = spinner.getSelectedItem().toString();
         Single<String> deletionReason = reasonBuilder.getReason(media, reason);
-        deletionReason
+        compositeDisposable.add(deletionReason
                 .subscribeOn(Schedulers.io())
                 .observeOn(AndroidSchedulers.mainThread())
                 .subscribe(s -> {
                     DeleteTask deleteTask = new DeleteTask(getActivity(), media, reason);
                     deleteTask.execute();
                     isDeleted = true;
                     enableDeleteButton(false);
-                });
+                }));
     }
 
     @OnClick(R.id.seeMore)