Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rails/jquery-ujs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: dcrec1/jquery-ujs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 17 commits
  • 1 file changed
  • 1 contributor

Commits on Feb 20, 2011

  1. refactored element.attr('data-x') to element.data('x')

    @dcrec1
    dcrec1 committed Feb 20, 2011
    Configuration menu
    Copy the full SHA
    4ce77d8 View commit details
    Browse the repository at this point in the history

  2. removed optional operator

    @dcrec1
    dcrec1 committed Feb 20, 2011
    Configuration menu
    Copy the full SHA
    0748cac View commit details
    Browse the repository at this point in the history

  3. refactored commented code to a function

    @dcrec1
    dcrec1 committed Feb 20, 2011
    Configuration menu
    Copy the full SHA
    ca5b4b6 View commit details
    Browse the repository at this point in the history

  4. dryed .live('x.rails') with .on(x)

    @dcrec1
    dcrec1 committed Feb 20, 2011
    Configuration menu
    Copy the full SHA
    0aa142f View commit details
    Browse the repository at this point in the history

  5. dryed 's ajax:beforeSend and ajax:complete

    @dcrec1
    dcrec1 committed Feb 20, 2011
    Configuration menu
    Copy the full SHA
    55a5c22 View commit details
    Browse the repository at this point in the history

  6. removed forgotten comment

    @dcrec1
    dcrec1 committed Feb 20, 2011
    Configuration menu
    Copy the full SHA
    ce01aad View commit details
    Browse the repository at this point in the history

  7. changed return false in favor of event.preventDefault, as what we rea… 

    …lly want is to prevent the default event of the elements and not to stop the event chain
    @dcrec1
    dcrec1 committed Feb 20, 2011
    Configuration menu
    Copy the full SHA
    60117d6 View commit details
    Browse the repository at this point in the history

  8. dryed code that execute an action if the event is allowed

    @dcrec1
    dcrec1 committed Feb 20, 2011
    Configuration menu
    Copy the full SHA
    af56c2d View commit details
    Browse the repository at this point in the history

  9. removed some ifs, instead of selecting a lot of elements and then ver… 

    …ifying the kind to know what behaviour to apply, select the elements of an specific kind and then apply the behaviour
    @dcrec1
    dcrec1 committed Feb 20, 2011
    Configuration menu
    Copy the full SHA
    b36c7d9 View commit details
    Browse the repository at this point in the history

  10. moved event.preventDefault to handleRemote and handleMethod, as this … 

    …go together always
    @dcrec1
    dcrec1 committed Feb 20, 2011
    Configuration menu
    Copy the full SHA
    5f29cdb View commit details
    Browse the repository at this point in the history

  11. dryied code

    @dcrec1
    dcrec1 committed Feb 20, 2011
    Configuration menu
    Copy the full SHA
    86f0900 View commit details
    Browse the repository at this point in the history

  12. refactored disableFormElements and enableFormElements, removed .each … 

    …in favor of .val
    @dcrec1
    dcrec1 committed Feb 20, 2011
    Configuration menu
    Copy the full SHA
    0524d7a View commit details
    Browse the repository at this point in the history

  13. dryed code by chained two methods

    @dcrec1
    dcrec1 committed Feb 20, 2011
    Configuration menu
    Copy the full SHA
    b593e71 View commit details
    Browse the repository at this point in the history

  14. refactored code that validates if required fields are missing

    @dcrec1
    dcrec1 committed Feb 20, 2011
    Configuration menu
    Copy the full SHA
    cbc01d0 View commit details
    Browse the repository at this point in the history

  15. removed if by dividing handleRemote into handleRemoteForm and handleR… 

    …emoteLink, as each one has a different behaviour
    @dcrec1
    dcrec1 committed Feb 20, 2011
    Configuration menu
    Copy the full SHA
    0cff309 View commit details
    Browse the repository at this point in the history

  16. refactored code, validating if the form is ok is part of handleRemote… 

    …Form
    @dcrec1
    dcrec1 committed Feb 20, 2011
    Configuration menu
    Copy the full SHA
    3f60112 View commit details
    Browse the repository at this point in the history

  17. dryed some code

    @dcrec1
    dcrec1 committed Feb 20, 2011
    Configuration menu
    Copy the full SHA
    fa139fd View commit details
    Browse the repository at this point in the history
Loading