Skip to content

Commit 200794a

Browse files
committed
rename
1 parent 5a54cba commit 200794a

File tree

4 files changed

+11
-16
lines changed

4 files changed

+11
-16
lines changed

ios/Handlers/RNNativeViewHandler.m

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -97,21 +97,21 @@ - (void)handleTouchDown:(UIView *)sender forEvent:(UIEvent *)event
9797
}
9898
}
9999

100-
[self sendStateTransitions:RNGestureHandlerStateActive
100+
[self sendStateTransitionIfNeeded:RNGestureHandlerStateActive
101101
forViewWithTag:sender.reactTag
102102
withExtraData:[RNGestureHandlerEventExtraData forPointerInside:YES]];
103103
}
104104

105105
- (void)handleTouchUpOutside:(UIView *)sender forEvent:(UIEvent *)event
106106
{
107-
[self sendStateTransitions:RNGestureHandlerStateEnd
107+
[self sendStateTransitionIfNeeded:RNGestureHandlerStateEnd
108108
forViewWithTag:sender.reactTag
109109
withExtraData:[RNGestureHandlerEventExtraData forPointerInside:NO]];
110110
}
111111

112112
- (void)handleTouchUpInside:(UIView *)sender forEvent:(UIEvent *)event
113113
{
114-
[self sendStateTransitions:RNGestureHandlerStateEnd
114+
[self sendStateTransitionIfNeeded:RNGestureHandlerStateEnd
115115
forViewWithTag:sender.reactTag
116116
withExtraData:[RNGestureHandlerEventExtraData forPointerInside:YES]];
117117
}
@@ -122,26 +122,26 @@ - (void)handleDragExit:(UIView *)sender forEvent:(UIEvent *)event
122122
if (self.shouldCancelWhenOutside) {
123123
UIControl *control = (UIControl *)sender;
124124
[control cancelTrackingWithEvent:event];
125-
[self sendStateTransitions:RNGestureHandlerStateEnd
125+
[self sendStateTransitionIfNeeded:RNGestureHandlerStateEnd
126126
forViewWithTag:sender.reactTag
127127
withExtraData:[RNGestureHandlerEventExtraData forPointerInside:NO]];
128128
} else {
129-
[self sendStateTransitions:RNGestureHandlerStateActive
129+
[self sendStateTransitionIfNeeded:RNGestureHandlerStateActive
130130
forViewWithTag:sender.reactTag
131131
withExtraData:[RNGestureHandlerEventExtraData forPointerInside:NO]];
132132
}
133133
}
134134

135135
- (void)handleDragEnter:(UIView *)sender forEvent:(UIEvent *)event
136136
{
137-
[self sendStateTransitions:RNGestureHandlerStateActive
137+
[self sendStateTransitionIfNeeded:RNGestureHandlerStateActive
138138
forViewWithTag:sender.reactTag
139139
withExtraData:[RNGestureHandlerEventExtraData forPointerInside:YES]];
140140
}
141141

142142
- (void)handleTouchCancel:(UIView *)sender forEvent:(UIEvent *)event
143143
{
144-
[self sendStateTransitions:RNGestureHandlerStateCancelled
144+
[self sendStateTransitionIfNeeded:RNGestureHandlerStateCancelled
145145
forViewWithTag:sender.reactTag
146146
withExtraData:[RNGestureHandlerEventExtraData forPointerInside:NO]];
147147
}

ios/Handlers/RNTapHandler.m

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,6 @@ - (void)touchesBegan:(NSSet<UITouch *> *)touches withEvent:(UIEvent *)event
8585
[self triggerAction];
8686
}
8787

88-
-(void) setState:(UIGestureRecognizerState)state {
89-
[super setState:state];
90-
[_gestureHandler handleGestureStateTransition:self];
91-
}
92-
9388
- (void)touchesMoved:(NSSet<UITouch *> *)touches withEvent:(UIEvent *)event
9489
{
9590
[super touchesMoved:touches withEvent:event];

ios/RNGestureHandler.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ if (value != nil) recognizer.prop = [RCTConvert type:value]; \
6969
forViewWithTag:(nonnull NSNumber *)reactTag
7070
withExtraData:(RNGestureHandlerEventExtraData *)extraData;
7171

72-
- (void)sendStateTransitions:(RNGestureHandlerState)state
72+
- (void)sendStateTransitionIfNeeded:(RNGestureHandlerState)state
7373
forViewWithTag:(nonnull NSNumber *)reactTag
7474
withExtraData:(RNGestureHandlerEventExtraData *)extraData;
7575

ios/RNGestureHandler.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ - (void)handleGesture:(UIGestureRecognizer *)recognizer
157157
- (void)handleGestureStateTransition:(UIGestureRecognizer *)recognizer
158158
{
159159
RNGestureHandlerEventExtraData *eventData = [self eventExtraData:recognizer];
160-
[self sendStateTransitions:self.state forViewWithTag:recognizer.view.reactTag withExtraData:eventData];
160+
[self sendStateTransitionIfNeeded:self.state forViewWithTag:recognizer.view.reactTag withExtraData:eventData];
161161
if (_lastState == UIGestureRecognizerStatePossible && (self.state == UIGestureRecognizerStateFailed || self.state == UIGestureRecognizerStateCancelled)) {
162162
// [self reset];
163163
}
@@ -173,13 +173,13 @@ - (void)sendEventsInState:(RNGestureHandlerState)state
173173
extraData:extraData];
174174

175175

176-
176+
[self sendStateTransitionIfNeeded:state forViewWithTag:reactTag withExtraData:extraData];
177177
if (state == RNGestureHandlerStateActive) {
178178
[self.emitter sendTouchEvent:touchEvent];
179179
}
180180
}
181181

182-
- (void) sendStateTransitions:(RNGestureHandlerState)state
182+
- (void) sendStateTransitionIfNeeded:(RNGestureHandlerState)state
183183
forViewWithTag:(nonnull NSNumber *)reactTag
184184
withExtraData:(RNGestureHandlerEventExtraData *)extraData {
185185
if (state != _lastState) {

0 commit comments

Comments
 (0)