Skip to content

Commit 01adc71

Browse files
Yu-wfacebook-github-bot
authored andcommitted
add cmd+opt+ctrl+D to globally invoke dev menu for Android
Reviewed By: frantic Differential Revision: D5280788 fbshipit-source-id: ce11d122ee17a2ba8d8aa2e91fc6639610791577
1 parent a2b0ee0 commit 01adc71

File tree

2 files changed

+17
-0
lines changed

2 files changed

+17
-0
lines changed

ReactAndroid/src/main/java/com/facebook/react/devsupport/DevServerHelper.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ public interface OnServerContentChangeListener {
9898

9999
public interface PackagerCommandListener {
100100
void onPackagerReloadCommand();
101+
void onPackagerDevMenuCommand();
101102
void onCaptureHeapCommand(final Responder responder);
102103
void onPokeSamplingProfilerCommand(final Responder responder);
103104
}
@@ -145,6 +146,12 @@ public void onNotification(@Nullable Object params) {
145146
commandListener.onPackagerReloadCommand();
146147
}
147148
});
149+
handlers.put("devMenu", new NotificationOnlyHandler() {
150+
@Override
151+
public void onNotification(@Nullable Object params) {
152+
commandListener.onPackagerDevMenuCommand();
153+
}
154+
});
148155
handlers.put("captureHeap", new RequestOnlyHandler() {
149156
@Override
150157
public void onRequest(@Nullable Object params, Responder responder) {

ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerImpl.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -682,6 +682,16 @@ public void run() {
682682
});
683683
}
684684

685+
@Override
686+
public void onPackagerDevMenuCommand() {
687+
UiThreadUtil.runOnUiThread(new Runnable() {
688+
@Override
689+
public void run() {
690+
showDevOptionsDialog();
691+
}
692+
});
693+
}
694+
685695
@Override
686696
public void onCaptureHeapCommand(final Responder responder) {
687697
UiThreadUtil.runOnUiThread(new Runnable() {

0 commit comments

Comments
 (0)